Add basic testing setup

Author: sjmiller609

.github/workflows/test.yml

@@ -0,0 +1,25 @@
+name: Test
+
+on:
+  push: {}
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.25'
+      
+      - name: Install dependencies
+        run: go mod download
+      
+      - name: Run tests
+        run: make test
+      
+      - name: Build
+        run: make build
+

Makefile

@@ -51,7 +51,7 @@ dev: $(AIR)
 
 # Run tests
 test:
-	go test -v ./...
+	go test -v -timeout 30s ./...
 
 # Clean generated files and binaries
 clean:

PATTERNS.md

@@ -236,26 +236,91 @@ make generate-all
 
 ## Testing Pattern
 
-(TODO: To be established when implementing actual functionality)
+### Handler-Level Tests
 
+Test by calling `ApiService` methods directly (not via HTTP). This is simple, fast, and matches the kernel API pattern.
+
+**Test Helper (cmd/api/api/api_test.go):**
 ```go
-package images_test
+package api
 
 import (
     "context"
     "testing"
 
+    "github.com/onkernel/cloud-hypervisor-dataplane/cmd/api/config"
     "github.com/onkernel/cloud-hypervisor-dataplane/lib/images"
+    "github.com/onkernel/cloud-hypervisor-dataplane/lib/instances"
+    "github.com/onkernel/cloud-hypervisor-dataplane/lib/volumes"
+)
+
+func newTestService(t *testing.T) *ApiService {
+    cfg := &config.Config{
+        DataDir: t.TempDir(),  // Creates isolated temp directory per test
+    }
+    
+    return &ApiService{
+        Config:          cfg,
+        ImageManager:    images.NewManager(cfg.DataDir),
+        InstanceManager: instances.NewManager(cfg.DataDir),
+        VolumeManager:   volumes.NewManager(cfg.DataDir),
+    }
+}
+
+func ctx() context.Context {
+    return context.Background()
+}
+```
+
+**Example Test (cmd/api/api/images_test.go):**
+```go
+package api
+
+import (
+    "testing"
+    
+    "github.com/onkernel/cloud-hypervisor-dataplane/lib/oapi"
+    "github.com/stretchr/testify/assert"
     "github.com/stretchr/testify/require"
 )
 
 func TestGetImage_NotFound(t *testing.T) {
-    mgr := images.NewManager("/tmp/test")
-    _, err := mgr.GetImage(context.Background(), "fake-id")
-    require.ErrorIs(t, err, images.ErrNotFound)
+    svc := newTestService(t)
+    
+    resp, err := svc.GetImage(ctx(), oapi.GetImageRequestObject{
+        Id: "non-existent",
+    })
+    require.NoError(t, err)
+    
+    notFound, ok := resp.(oapi.GetImage404JSONResponse)
+    require.True(t, ok, "expected 404 response")
+    assert.Equal(t, "not_found", notFound.Code)
+    assert.Equal(t, "image not found", notFound.Message)
+}
+
+func TestListImages_Empty(t *testing.T) {
+    svc := newTestService(t)
+    
+    resp, err := svc.ListImages(ctx(), oapi.ListImagesRequestObject{})
+    require.NoError(t, err)
+    
+    list, ok := resp.(oapi.ListImages200JSONResponse)
+    require.True(t, ok, "expected 200 response")
+    assert.Empty(t, list)
 }
 ```
 
+### Running Tests
+
+```bash
+make test                    # Run all tests
+go test -v ./cmd/api/api/   # Run handler tests only
+```
+
+### CI Integration
+
+Tests run automatically on GitHub via `.github/workflows/test.yml` on push and PR.
+
 ## Comments
 
 From workspace rules:

README.md

@@ -1,5 +1,7 @@
 # Cloud Hypervisor Dataplane API
 
+[![Test](https://github.com/onkernel/cloud-hypervisor-dataplane/actions/workflows/test.yml/badge.svg)](https://github.com/onkernel/cloud-hypervisor-dataplane/actions/workflows/test.yml)
+
 A generic dataplane API for managing VM lifecycle using Cloud Hypervisor with OCI-based workloads. This project provides a clean, REST-ful interface for creating, managing, and orchestrating VMs from container images.
 
 ## Features
@@ -189,10 +191,18 @@ make generate-all
 
 ### Testing
 
+Run all tests:
 ```bash
 make test
 ```
 
+Run specific package:
+```bash
+go test -v ./cmd/api/api/
+```
+
+Tests are handler-level tests that call `ApiService` methods directly (no HTTP server needed).
+
 ### Building
 
 ```bash

cmd/api/api/api_test.go

@@ -0,0 +1,30 @@
+package api
+
+import (
+	"context"
+	"testing"
+
+	"github.com/onkernel/cloud-hypervisor-dataplane/cmd/api/config"
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/images"
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/instances"
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/volumes"
+)
+
+// newTestService creates an ApiService for testing with temporary data directory
+func newTestService(t *testing.T) *ApiService {
+	cfg := &config.Config{
+		DataDir: t.TempDir(),
+	}
+
+	return &ApiService{
+		Config:          cfg,
+		ImageManager:    images.NewManager(cfg.DataDir),
+		InstanceManager: instances.NewManager(cfg.DataDir),
+		VolumeManager:   volumes.NewManager(cfg.DataDir),
+	}
+}
+
+func ctx() context.Context {
+	return context.Background()
+}
+

cmd/api/api/images_test.go

@@ -0,0 +1,35 @@
+package api
+
+import (
+	"testing"
+
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/oapi"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestListImages_Empty(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.ListImages(ctx(), oapi.ListImagesRequestObject{})
+	require.NoError(t, err)
+
+	list, ok := resp.(oapi.ListImages200JSONResponse)
+	require.True(t, ok, "expected 200 response")
+	assert.Empty(t, list)
+}
+
+func TestGetImage_NotFound(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.GetImage(ctx(), oapi.GetImageRequestObject{
+		Id: "non-existent",
+	})
+	require.NoError(t, err)
+
+	notFound, ok := resp.(oapi.GetImage404JSONResponse)
+	require.True(t, ok, "expected 404 response")
+	assert.Equal(t, "not_found", notFound.Code)
+	assert.Equal(t, "image not found", notFound.Message)
+}
+

cmd/api/api/instances_test.go

@@ -0,0 +1,34 @@
+package api
+
+import (
+	"testing"
+
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/oapi"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestListInstances_Empty(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.ListInstances(ctx(), oapi.ListInstancesRequestObject{})
+	require.NoError(t, err)
+
+	list, ok := resp.(oapi.ListInstances200JSONResponse)
+	require.True(t, ok, "expected 200 response")
+	assert.Empty(t, list)
+}
+
+func TestGetInstance_NotFound(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.GetInstance(ctx(), oapi.GetInstanceRequestObject{
+		Id: "non-existent",
+	})
+	require.NoError(t, err)
+
+	notFound, ok := resp.(oapi.GetInstance404JSONResponse)
+	require.True(t, ok, "expected 404 response")
+	assert.Equal(t, "not_found", notFound.Code)
+}
+

cmd/api/api/volumes_test.go

@@ -0,0 +1,34 @@
+package api
+
+import (
+	"testing"
+
+	"github.com/onkernel/cloud-hypervisor-dataplane/lib/oapi"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestListVolumes_Empty(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.ListVolumes(ctx(), oapi.ListVolumesRequestObject{})
+	require.NoError(t, err)
+
+	list, ok := resp.(oapi.ListVolumes200JSONResponse)
+	require.True(t, ok, "expected 200 response")
+	assert.Empty(t, list)
+}
+
+func TestGetVolume_NotFound(t *testing.T) {
+	svc := newTestService(t)
+
+	resp, err := svc.GetVolume(ctx(), oapi.GetVolumeRequestObject{
+		Id: "non-existent",
+	})
+	require.NoError(t, err)
+
+	notFound, ok := resp.(oapi.GetVolume404JSONResponse)
+	require.True(t, ok, "expected 404 response")
+	assert.Equal(t, "not_found", notFound.Code)
+}
+

go.mod

@@ -8,11 +8,13 @@ require (
 	github.com/go-chi/chi/v5 v5.2.3
 	github.com/google/wire v0.7.0
 	github.com/oapi-codegen/runtime v1.1.2
+	github.com/stretchr/testify v1.11.1
 	golang.org/x/sync v0.17.0
 )
 
 require (
 	github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect
+	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/go-openapi/jsonpointer v0.21.0 // indirect
 	github.com/go-openapi/swag v0.23.0 // indirect
 	github.com/google/uuid v1.5.0 // indirect
@@ -22,6 +24,7 @@ require (
 	github.com/oasdiff/yaml v0.0.0-20250309154309-f31be36b4037 // indirect
 	github.com/oasdiff/yaml3 v0.0.0-20250309153720-d2182401db90 // indirect
 	github.com/perimeterx/marshmallow v1.1.5 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/woodsbury/decimal128 v1.3.0 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect

go.sum

@@ -47,8 +47,8 @@ github.com/rogpeppe/go-internal v1.12.0/go.mod h1:E+RYuTGaKKdloAfM02xzb0FW3Paa99
 github.com/spkg/bom v0.0.0-20160624110644-59b7046e48ad/go.mod h1:qLr4V1qq6nMqFKkMo8ZTx3f+BZEkzsRUY10Xsm2mwU0=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
-github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
-github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
+github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
 github.com/ugorji/go/codec v1.2.11 h1:BMaWp1Bb6fHwEtbplGBGJ498wD+LKlNSl25MjdZY4dU=
 github.com/ugorji/go/codec v1.2.11/go.mod h1:UNopzCgEMSXjBc6AOMqYvWC1ktqTAfzJZUZgYf6w6lg=
 github.com/woodsbury/decimal128 v1.3.0 h1:8pffMNWIlC0O5vbyHWFZAt5yWvWcrHA+3ovIIjVWss0=