Remove reboot for now

Author: sjmiller609

cmd/api/api/instances.go

@@ -426,53 +426,6 @@ func (s *ApiService) StartInstance(ctx context.Context, request oapi.StartInstan
 	return oapi.StartInstance200JSONResponse(instanceToOAPI(*inst)), nil
 }
 
-// RebootInstance reboots a running instance
-// The id parameter can be an instance ID, name, or ID prefix
-func (s *ApiService) RebootInstance(ctx context.Context, request oapi.RebootInstanceRequestObject) (oapi.RebootInstanceResponseObject, error) {
-	log := logger.FromContext(ctx)
-
-	// Resolve to get the actual instance ID
-	resolved, err := s.InstanceManager.GetInstance(ctx, request.Id)
-	if err != nil {
-		switch {
-		case errors.Is(err, instances.ErrNotFound):
-			return oapi.RebootInstance404JSONResponse{
-				Code:    "not_found",
-				Message: "instance not found",
-			}, nil
-		case errors.Is(err, instances.ErrAmbiguousName):
-			return oapi.RebootInstance404JSONResponse{
-				Code:    "ambiguous",
-				Message: "multiple instances match, use full instance ID",
-			}, nil
-		default:
-			log.ErrorContext(ctx, "failed to get instance", "error", err, "id", request.Id)
-			return oapi.RebootInstance500JSONResponse{
-				Code:    "internal_error",
-				Message: "failed to get instance",
-			}, nil
-		}
-	}
-
-	inst, err := s.InstanceManager.RebootInstance(ctx, resolved.Id)
-	if err != nil {
-		switch {
-		case errors.Is(err, instances.ErrInvalidState):
-			return oapi.RebootInstance409JSONResponse{
-				Code:    "invalid_state",
-				Message: err.Error(),
-			}, nil
-		default:
-			log.ErrorContext(ctx, "failed to reboot instance", "error", err, "id", resolved.Id)
-			return oapi.RebootInstance500JSONResponse{
-				Code:    "internal_error",
-				Message: "failed to reboot instance",
-			}, nil
-		}
-	}
-	return oapi.RebootInstance200JSONResponse(instanceToOAPI(*inst)), nil
-}
-
 // logsStreamResponse implements oapi.GetInstanceLogsResponseObject with proper SSE flushing
 type logsStreamResponse struct {
 	logChan <-chan string

cmd/api/api/instances_test.go

@@ -128,7 +128,7 @@ func TestCreateInstance_InvalidSizeFormat(t *testing.T) {
 	assert.Contains(t, badReq.Message, "invalid size format")
 }
 
-func TestInstanceLifecycle_StopStartReboot(t *testing.T) {
+func TestInstanceLifecycle_StopStart(t *testing.T) {
 	// Require KVM access for VM creation
 	if _, err := os.Stat("/dev/kvm"); os.IsNotExist(err) {
 		t.Skip("/dev/kvm not available - skipping lifecycle test")
@@ -194,17 +194,7 @@ func TestInstanceLifecycle_StopStartReboot(t *testing.T) {
 	// Wait for Running state after start
 	waitForState(t, svc, instanceID, "Running", 30*time.Second)
 
-	// 4. Reboot the instance
-	t.Log("Rebooting instance...")
-	rebootResp, err := svc.RebootInstance(ctx(), oapi.RebootInstanceRequestObject{Id: instanceID})
-	require.NoError(t, err)
-
-	rebooted, ok := rebootResp.(oapi.RebootInstance200JSONResponse)
-	require.True(t, ok, "expected 200 response for reboot, got %T", rebootResp)
-	assert.Equal(t, oapi.InstanceState("Running"), rebooted.State)
-	t.Log("Instance rebooted successfully")
-
-	// 5. Cleanup - delete the instance
+	// 4. Cleanup - delete the instance
 	t.Log("Deleting instance...")
 	deleteResp, err := svc.DeleteInstance(ctx(), oapi.DeleteInstanceRequestObject{Id: instanceID})
 	require.NoError(t, err)

lib/instances/manager.go

@@ -26,7 +26,6 @@ type Manager interface {
 	RestoreInstance(ctx context.Context, id string) (*Instance, error)
 	StopInstance(ctx context.Context, id string) (*Instance, error)
 	StartInstance(ctx context.Context, id string) (*Instance, error)
-	RebootInstance(ctx context.Context, id string) (*Instance, error)
 	StreamInstanceLogs(ctx context.Context, id string, tail int, follow bool) (<-chan string, error)
 	RotateLogs(ctx context.Context, maxBytes int64, maxFiles int) error
 	AttachVolume(ctx context.Context, id string, volumeId string, req AttachVolumeRequest) (*Instance, error)
@@ -141,14 +140,6 @@ func (m *manager) StartInstance(ctx context.Context, id string) (*Instance, erro
 	return m.startInstance(ctx, id)
 }
 
-// RebootInstance reboots a running instance
-func (m *manager) RebootInstance(ctx context.Context, id string) (*Instance, error) {
-	lock := m.getInstanceLock(id)
-	lock.Lock()
-	defer lock.Unlock()
-	return m.rebootInstance(ctx, id)
-}
-
 // ListInstances returns all instances
 func (m *manager) ListInstances(ctx context.Context) ([]Instance, error) {
 	// No lock - eventual consistency is acceptable for list operations.

lib/instances/metrics.go

@@ -16,7 +16,6 @@ type Metrics struct {
 	standbyDuration  metric.Float64Histogram
 	stopDuration     metric.Float64Histogram
 	startDuration    metric.Float64Histogram
-	rebootDuration   metric.Float64Histogram
 	stateTransitions metric.Int64Counter
 	tracer           trace.Tracer
 }
@@ -68,15 +67,6 @@ func newInstanceMetrics(meter metric.Meter, tracer trace.Tracer, m *manager) (*M
 		return nil, err
 	}
 
-	rebootDuration, err := meter.Float64Histogram(
-		"hypeman_instances_reboot_duration_seconds",
-		metric.WithDescription("Time to reboot an instance"),
-		metric.WithUnit("s"),
-	)
-	if err != nil {
-		return nil, err
-	}
-
 	stateTransitions, err := meter.Int64Counter(
 		"hypeman_instances_state_transitions_total",
 		metric.WithDescription("Total number of instance state transitions"),
@@ -122,7 +112,6 @@ func newInstanceMetrics(meter metric.Meter, tracer trace.Tracer, m *manager) (*M
 		standbyDuration:  standbyDuration,
 		stopDuration:     stopDuration,
 		startDuration:    startDuration,
-		rebootDuration:   rebootDuration,
 		stateTransitions: stateTransitions,
 		tracer:           tracer,
 	}, nil