feat: update api to host update.xml and retrive .crx

Author: archandatta

images/chromium-headful/run-docker.sh

@@ -63,7 +63,7 @@ RUN_ARGS=(
   -e WIDTH=1920
   -e TZ=${TZ:-'America/Los_Angeles'}
   -e RUN_AS_ROOT="$RUN_AS_ROOT"
-  --mount type=bind,src="$FLAGS_FILE",dst=/chromium/flags,ro
+  --mount type=bind,src="$FLAGS_FILE",dst=/chromium/flags
 )
 
 if [[ -n "${PLAYWRIGHT_ENGINE:-}" ]]; then

server/cmd/api/api/chromium.go

@@ -157,10 +157,34 @@ func (s *ApiService) UploadExtensionsAndRestart(ctx context.Context, request oap
 			log.Error("failed to chown extension dir", "error", err)
 			return oapi.UploadExtensionsAndRestart500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to chown extension dir"}}, nil
 		}
+
+		// Check if the zip contains update.xml and .crx files (for policy-installed extensions)
+		// If they exist, they'll be extracted; if not, they need to be generated separately
+		updateXMLPath := filepath.Join(dest, "update.xml")
+		crxPath := filepath.Join(dest, p.name+".crx")
+		hasUpdateXML := false
+		hasCRX := false
+
+		if _, err := os.Stat(updateXMLPath); err == nil {
+			hasUpdateXML = true
+			log.Info("found update.xml in extension zip", "name", p.name)
+		}
+		if _, err := os.Stat(crxPath); err == nil {
+			hasCRX = true
+			log.Info("found .crx file in extension zip", "name", p.name)
+		}
+
+		if !hasUpdateXML || !hasCRX {
+			log.Info("extension zip missing update.xml or .crx - these files should be included for policy-installed extensions", "name", p.name, "hasUpdateXML", hasUpdateXML, "hasCRX", hasCRX)
+		}
+
 		log.Info("installed extension", "name", p.name)
 	}
 
 	// Update enterprise policy for extensions that require it
+	// Track which extensions need --load-extension flags (those NOT using policy installation)
+	var pathsNeedingFlags []string
+
 	for _, p := range items {
 		extensionPath := filepath.Join(extBase, p.name)
 		extensionID := s.policy.GenerateExtensionID(p.name)
@@ -175,6 +199,9 @@ func (s *ApiService) UploadExtensionsAndRestart(ctx context.Context, request oap
 
 		if requiresEntPolicy {
 			log.Info("extension requires enterprise policy", "name", p.name)
+		} else {
+			// Only add --load-extension flags for non-policy extensions
+			pathsNeedingFlags = append(pathsNeedingFlags, extensionPath)
 		}
 
 		// Add to enterprise policy
@@ -191,15 +218,13 @@ func (s *ApiService) UploadExtensionsAndRestart(ctx context.Context, request oap
 	}
 
 	// Build flags overlay file in /chromium/flags, merging with existing flags
-	var paths []string
-	for _, p := range items {
-		paths = append(paths, filepath.Join(extBase, p.name))
-	}
-
-	// Create new flags for the uploaded extensions
-	newTokens := []string{
-		fmt.Sprintf("--disable-extensions-except=%s", strings.Join(paths, ",")),
-		fmt.Sprintf("--load-extension=%s", strings.Join(paths, ",")),
+	// Only add --load-extension flags for extensions that don't use policy installation
+	var newTokens []string
+	if len(pathsNeedingFlags) > 0 {
+		newTokens = []string{
+			fmt.Sprintf("--disable-extensions-except=%s", strings.Join(pathsNeedingFlags, ",")),
+			fmt.Sprintf("--load-extension=%s", strings.Join(pathsNeedingFlags, ",")),
+		}
 	}
 
 	// Merge and write flags

server/cmd/api/main.go

@@ -124,6 +124,64 @@ func main() {
 		apiService.HandleProcessAttach(w, r, id)
 	})
 
+	// Serve extension files for Chrome policy-installed extensions
+	// This allows Chrome to download .crx and update.xml files via HTTP
+	extensionsDir := "/home/kernel/extensions"
+	r.Get("/extensions/*", func(w http.ResponseWriter, r *http.Request) {
+		// Serve files from /home/kernel/extensions/
+		fs := http.StripPrefix("/extensions/", http.FileServer(http.Dir(extensionsDir)))
+		fs.ServeHTTP(w, r)
+	})
+
+	// Serve update.xml at root for Chrome enterprise policy
+	// This serves the first update.xml found in any extension directory
+	r.Get("/update.xml", func(w http.ResponseWriter, r *http.Request) {
+		// Try to find update.xml in the first extension directory
+		entries, err := os.ReadDir(extensionsDir)
+		if err != nil {
+			http.Error(w, "extensions directory not found", http.StatusNotFound)
+			return
+		}
+
+		for _, entry := range entries {
+			if entry.IsDir() {
+				updateXMLPath := fmt.Sprintf("%s/%s/update.xml", extensionsDir, entry.Name())
+				if _, err := os.Stat(updateXMLPath); err == nil {
+					http.ServeFile(w, r, updateXMLPath)
+					return
+				}
+			}
+		}
+
+		http.Error(w, "update.xml not found", http.StatusNotFound)
+	})
+
+	// Serve CRX files at root for Chrome enterprise policy
+	// This allows simple codebase URLs like http://host:port/extension-name.crx
+	r.Get("/{filename}.crx", func(w http.ResponseWriter, r *http.Request) {
+		// Extract the filename from the URL path
+		filename := chi.URLParam(r, "filename") + ".crx"
+
+		// Search for the CRX file in all extension directories
+		entries, err := os.ReadDir(extensionsDir)
+		if err != nil {
+			http.Error(w, "extensions directory not found", http.StatusNotFound)
+			return
+		}
+
+		for _, entry := range entries {
+			if entry.IsDir() {
+				crxPath := fmt.Sprintf("%s/%s/%s", extensionsDir, entry.Name(), filename)
+				if _, err := os.Stat(crxPath); err == nil {
+					http.ServeFile(w, r, crxPath)
+					return
+				}
+			}
+		}
+
+		http.Error(w, "crx file not found", http.StatusNotFound)
+	})
+
 	srv := &http.Server{
 		Addr:    fmt.Sprintf(":%d", config.Port),
 		Handler: r,