src/bin: fix possible toctou in erase

troglobit · troglobit · commit bdc391b4ce69 · 2025-08-04T08:07:38.000+02:00
Found by Coverity Scan

Signed-off-by: Joachim Wiberg &lt;troglobit@gmail.com&gt;
diff --git a/src/bin/erase.c b/src/bin/erase.c
@@ -26,10 +26,6 @@ static int do_erase(const char *path)
 		}
 
 		cfg_adjust(path, NULL, fn, len);
-		if (access(fn, F_OK)) {
-			fprintf(stderr, "No such file: %s\n", fn);
-			return -1;
-		}
 	} else
 		fn = (char *)path;
 

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,6 @@ static int do_erase(const char *path)`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`cfg_adjust(path, NULL, fn, len);`
`29`		`- if (access(fn, F_OK)) {`
`30`		`- fprintf(stderr, "No such file: %s\n", fn);`
`31`		`- return -1;`
`32`		`- }`
`33`	`29`	`} else`
`34`	`30`	`fn = (char *)path;`
`35`	`31`