Skip to content

Commit c59f53e

Browse files
authored
Merge pull request #1163 from kernelkit/finit-warning
Fix log error at boot about unsupported command
2 parents fe8610b + 040bd5b commit c59f53e

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

doc/ChangeLog.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ Change Log
33

44
All notable changes to the project are documented in this file.
55

6-
[v25.09.0][UNRELEASED] -
6+
[v25.09.0][] - 2025-09-30
77
-------------------------
88

99
### Changes
10+
1011
- Upgrade Buildroot to 2025.02.6 (LTS)
1112
- Upgrade Linux kernel to 6.12.46 (LTS)
1213
- Upgrade libyang to 3.13.5
@@ -20,12 +21,14 @@ All notable changes to the project are documented in this file.
2021
- cli: new `terminal reset` and `terminal resize` convenience commands
2122

2223
### Fixes
24+
2325
- Fix #1080: Error message in log from rauc, deprecated 'Install' D-Bus method
2426
- Fix #1100: Reduce DHCP client logging verbosity by 70% and include interface
2527
names in log messages for easier troubleshooting
2628
- Fix #1119: CLI UX regression, restore proper behavior for `no enabled` command
2729
- Fix #1155: `show ospf` commands regression
28-
- Fix #1150: show-legacy wrapper permissions
30+
- Fix #1150: `show-legacy` wrapper permissions
31+
- Fix #1161: error in log during boot about unsupported command
2932
- Fixes for unicode translation in log and pager outputs as well as `syslogd`
3033

3134
[BPI-R3]: https://wiki.banana-pi.org/Banana_Pi_BPI-R3

patches/openresolv/3.13.2/finit-support.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ diff -ru openresolv-3.12.0.orig/resolvconf.in openresolv-3.12.0/resolvconf.in
66
/usr/bin/systemctl restart $1.service
77
fi'
88
+ elif [ -x /sbin/initctl ]; then
9-
+ RESTARTCMD="/sbin/initctl -bnq restart \$1"
9+
+ RESTARTCMD="runlevel >/dev/null 2>&1 && /sbin/initctl -bnq restart \$1"
1010
elif [ -x /sbin/rc-service ] &&
1111
{ [ -s /libexec/rc/init.d/softlevel ] ||
1212
[ -s /run/openrc/softlevel ]; }

src/confd/src/infix-dhcp-server.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ static void del(const char *subnet, struct lyd_node *cfg)
240240
int prefix_len;
241241
char line[512];
242242

243-
systemf("initctl -nbq stop dnsmasq");
244243
fremove(DNSMASQ_SUBNET_FMT, subnet_tag(subnet));
245244

246245
/* Parse subnet/prefix */
@@ -369,7 +368,6 @@ static int change(sr_session_ctx_t *session, uint32_t sub_id, const char *module
369368
if (err)
370369
goto err_done;
371370
} else {
372-
system("initctl -nbq stop dnsmasq"), deleted++;
373371
erase(DNSMASQ_LEASES);
374372
erase(DNSMASQ_GLOBAL_OPTS);
375373

@@ -382,9 +380,7 @@ static int change(sr_session_ctx_t *session, uint32_t sub_id, const char *module
382380
}
383381

384382
err_done:
385-
if (deleted)
386-
system("initctl -nbq restart dnsmasq");
387-
else
383+
if (added || deleted)
388384
system("initctl -nbq touch dnsmasq");
389385

390386
lyd_free_tree(diff);

0 commit comments

Comments
 (0)