Merge pull request rapid7#19612 from rapid7/revert-19554-new-junction-test

Revert "Added new failing test for windows junction points"

Author: adfoster-r7

test/modules/post/test/file.rb

@@ -117,27 +117,6 @@ def test_dir
         ret
       end
     end
-
-    if (session.platform == 'windows')
-      it 'should delete a junction target' do
-        mkdir(datastore['BaseDirectoryName'])
-        ret = directory?(datastore['BaseDirectoryName'])
-        link = "#{datastore['BaseDirectoryName']}.junc"
-        ret &&= write_file([datastore['BaseDirectoryName'], 'file'].join(fs_sep), '')
-        make_junction(datastore['BaseDirectoryName'], link)
-        unless exists?(link)
-          print_error('failed to create the symbolic link')
-        end
-        rm_rf(link)
-        # the link should have been deleted
-        ret &&= !exists?(link)
-        # but the target directory and its contents should still be intact
-        ret &&= exists?("#{[datastore['BaseDirectoryName'], 'file'].join(fs_sep)}")
-        rm_rf(datastore['BaseDirectoryName'])
-        ret
-      end
-    end
-
   end
 
   def test_file
@@ -310,10 +289,6 @@ def test_path_expansion_nix
     end
   end
 
-  def make_junction(target, symlink)
-    cmd_exec("cmd.exe", "/c mklink #{directory?(target) ? '/J ' : ''}#{symlink} #{target}")
-  end
-
   def make_symlink(target, symlink)
     if session.platform == 'windows'
       cmd_exec("cmd.exe", "/c mklink #{directory?(target) ? '/D ' : ''}#{symlink} #{target}")