[Security Solution] [AI assistant] Make Security AI assistant tools available even when the chat completion endpoint is called from outside of security. (elastic#226206)

## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

This PR makes AI assistant tools registered by the security solution
available when the assistant is invoked by other plugins. This is part
of a larger effort to make the Security AI assistant globally
accessible.

### How to test
Code only review is fine. 

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [X]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [X] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [X] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [X] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>

Author: 2 people

x-pack/solutions/security/plugins/elastic_assistant/server/plugin.ts

@@ -194,7 +194,7 @@ export class ElasticAssistantPlugin
       getRegisteredFeatures: (pluginName: string) => {
         return appContextService.getRegisteredFeatures(pluginName);
       },
-      getRegisteredTools: (pluginName: string) => {
+      getRegisteredTools: (pluginName: string | string[]) => {
         return appContextService.getRegisteredTools(pluginName);
       },
     };
@@ -220,7 +220,7 @@ export class ElasticAssistantPlugin
       getRegisteredFeatures: (pluginName: string) => {
         return appContextService.getRegisteredFeatures(pluginName);
       },
-      getRegisteredTools: (pluginName: string) => {
+      getRegisteredTools: (pluginName: string | string[]) => {
         return appContextService.getRegisteredTools(pluginName);
       },
       registerFeatures: (pluginName: string, features: Partial<AssistantFeatures>) => {

x-pack/solutions/security/plugins/elastic_assistant/server/routes/helpers.ts

@@ -293,8 +293,10 @@ export const langChainExecute = async ({
   const assistantContext = context.elasticAssistant;
   // We don't (yet) support invoking these tools interactively
   const unsupportedTools = new Set(['attack-discovery', DEFEND_INSIGHTS_ID]);
+  const pluginNames = Array.from(new Set([pluginName, DEFAULT_PLUGIN_NAME]));
+
   const assistantTools = assistantContext
-    .getRegisteredTools(pluginName)
+    .getRegisteredTools(pluginNames)
     .filter((tool) => !unsupportedTools.has(tool.id));
 
   // get a scoped esClient for assistant memory

x-pack/solutions/security/plugins/elastic_assistant/server/routes/request_context_factory.ts

@@ -107,7 +107,7 @@ export class RequestContextFactory implements IRequestContextFactory {
 
       getCurrentUser,
 
-      getRegisteredTools: (pluginName: string) => {
+      getRegisteredTools: (pluginName: string | string[]) => {
         return appContextService.getRegisteredTools(pluginName);
       },
 

x-pack/solutions/security/plugins/elastic_assistant/server/services/app_context.test.ts

@@ -35,6 +35,14 @@ describe('AppContextService', () => {
     isSupported: jest.fn(),
     getTool: jest.fn(),
   };
+  const toolThree: AssistantTool = {
+    id: 'tool-three',
+    name: 'ToolThree',
+    description: 'Description 3',
+    sourceRegister: 'Source3',
+    isSupported: jest.fn(),
+    getTool: jest.fn(),
+  };
 
   beforeEach(() => {
     appContextService.stop();
@@ -99,6 +107,17 @@ describe('AppContextService', () => {
     });
   });
 
+  it('get tools for multiple plugins', () => {
+    const pluginName1 = 'pluginName1';
+    const pluginName2 = 'pluginName2';
+
+    appContextService.start(mockAppContext);
+    appContextService.registerTools(pluginName2, [toolOne, toolThree]);
+    appContextService.registerTools(pluginName1, [toolOne]);
+
+    expect(appContextService.getRegisteredTools([pluginName1, pluginName2]).length).toEqual(2);
+  });
+
   describe('registering features', () => {
     it('should register and get features for a single plugin', () => {
       const pluginName = 'pluginName';

x-pack/solutions/security/plugins/elastic_assistant/server/services/app_context.ts

@@ -12,7 +12,7 @@ import { AssistantTool } from '../types';
 export type PluginName = string;
 export type RegisteredToolsStorage = Map<PluginName, Set<AssistantTool>>;
 export type RegisteredFeaturesStorage = Map<PluginName, AssistantFeatures>;
-export type GetRegisteredTools = (pluginName: string) => AssistantTool[];
+export type GetRegisteredTools = (pluginName: string | string[]) => AssistantTool[];
 export type GetRegisteredFeatures = (pluginName: string) => AssistantFeatures;
 export interface ElasticAssistantAppContext {
   logger: Logger;
@@ -67,8 +67,16 @@ class AppContextService {
    *
    * @param pluginName
    */
-  public getRegisteredTools(pluginName: string): AssistantTool[] {
-    const tools = Array.from(this.registeredTools?.get(pluginName) ?? new Set<AssistantTool>());
+  public getRegisteredTools(pluginName: string | string[]): AssistantTool[] {
+    const pluginNames = Array.isArray(pluginName) ? pluginName : [pluginName];
+
+    const tools = [
+      ...new Set(
+        pluginNames
+          .map((name) => this.registeredTools?.get(name) ?? new Set<AssistantTool>())
+          .flatMap((set) => [...set])
+      ),
+    ];
 
     this.logger?.debug('AppContextService:getRegisteredTools');
     this.logger?.debug(`pluginName: ${pluginName}`);