fix(configure): properly resolve package.json on windows (#14)

* fix(configure): use proper path to load package.json on windows

* ci: only run tests on main or pr

Author: kerwanp

.changeset/blue-hairs-hunt.md

@@ -0,0 +1,5 @@
+---
+'adonis-cockpit': patch
+---
+
+Fix configuration on Windows

.github/workflows/test.yml

@@ -1,8 +1,10 @@
 name: test
 
 on:
-  - push
-  - pull_request
+  push:
+    branches:
+      - main
+  pull_request:
 
 jobs:
   lint:

README.md

@@ -14,8 +14,8 @@
 
 #### [🚀 Get started](https://adonis-cockpit.com/docs/getting-started/installation) • [🌐 Website](https://adonis-cockpit.com/docs/getting-started/installation) • [✍ Contribute](./CONTRIBUTING.md)
 
-![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/kerwanp/adonis-cockpit/test?style=flat-square&label=tests)
-![Lines](https://img.shields.io/badge/coverage-20.21%25-red.svg?style=flat-square) [![adonis-cockpit](https://img.shields.io/npm/v/adonis-cockpit?style=flat-square)](https://www.npmjs.com/package/adonis-cockpit)
+![GitHub branch check runs](https://img.shields.io/github/check-runs/kerwanp/adonis-cockpit/main?style=flat-square)
+![Lines](https://img.shields.io/badge/coverage-19.94%25-red.svg?style=flat-square) [![adonis-cockpit](https://img.shields.io/npm/v/adonis-cockpit?style=flat-square)](https://www.npmjs.com/package/adonis-cockpit)
 
 [![PRs Welcome](https://img.shields.io/badge/PRs-Are%20welcome-brightgreen.svg?style=flat-square)](https://makeapullrequest.com) [![License](https://img.shields.io/github/license/kerwanp/adonis-cockpit?label=License&style=flat-square)](LICENCE)
 

configure.ts

@@ -46,7 +46,7 @@ const missingDependenciesSteps: {
   {
     title: 'Lucid is not configured',
     detect: async (command) => {
-      const packageJson = await PackageJson.load(command.app.appRoot.pathname)
+      const packageJson = await PackageJson.load(command.app.makePath())
       const dependencies = Object.keys(packageJson.content.dependencies ?? [])
       return dependencies.includes('@adonisjs/lucid')
     },
@@ -58,7 +58,7 @@ const missingDependenciesSteps: {
   {
     title: 'InertiaJS is not configured',
     detect: async (command) => {
-      const packageJson = await PackageJson.load(command.app.appRoot.pathname)
+      const packageJson = await PackageJson.load(command.app.makePath())
       const dependencies = Object.keys(packageJson.content.dependencies ?? [])
       return dependencies.includes('@adonisjs/inertia')
     },
@@ -199,7 +199,7 @@ async function installTailwindCSS(command: ConfigureCommand, codemods: Codemods)
 }
 
 async function updatePackageJson(command: ConfigureCommand) {
-  const packageJson = await PackageJson.load(command.app.appRoot.pathname)
+  const packageJson = await PackageJson.load(command.app.makePath())
 
   packageJson.update({
     imports: {

tests/integration/configure.test.ts

@@ -30,7 +30,7 @@ async function prepareApp(
   await writeFile(app.makePath('start/env.ts'), `export default Env.create(new URL('./'), {})`)
   await writeFile(app.makePath('adonisrc.ts'), 'export default defineConfig({})')
   await writeFile(app.makePath('vite.config.ts'), 'export default defineConfig({ plugins: [] })')
-  await PackageJson.create(app.appRoot.pathname)
+  await PackageJson.create(app.makePath())
     .then((p) => p.update(packageJson))
     .then((p) => p.save())
 }