Skip to content

Commit 831fdb0

Browse files
hanhanWkeshavvinayak01
authored andcommitted
[GPU][NFC] Deprecate iree-codegen-gpu-native-math-precision flag. (iree-org#21636)
Signed-off-by: hanhanW <[email protected]> Signed-off-by: keshavvinayak01 <[email protected]>
1 parent 0ce852e commit 831fdb0

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

compiler/src/iree/compiler/Codegen/Common/MathTransformPass.cpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,6 @@
1616

1717
namespace mlir::iree_compiler {
1818

19-
/// Deprecated! This flag had buggy/unintentional semantics.
20-
/// Its original comment said:
21-
/// ""use native hardware operations instead of polynomial approximation".
22-
static llvm::cl::opt<bool> clNativeMathPrecision(
23-
"iree-codegen-gpu-native-math-precision",
24-
llvm::cl::desc("Deprecated! This flag doesn't do anything anymore and will "
25-
"be removed soon."),
26-
llvm::cl::init(false));
27-
2819
#define GEN_PASS_DEF_MATHTRANSFORMPASS
2920
#include "iree/compiler/Codegen/Common/Passes.h.inc"
3021

@@ -173,27 +164,12 @@ static bool predicateDeviceLibImpl(StringRef name,
173164

174165
namespace {
175166

176-
struct DeprecationWarningForNativeMathPrecision {
177-
DeprecationWarningForNativeMathPrecision() {
178-
if (clNativeMathPrecision) {
179-
clNativeMathPrecision.error(
180-
"This option is deprecated, does not do anything anymore, and will "
181-
"be removed soon. It was mainly used on the ROCm target, but the "
182-
"behavior that it once enabled is now default on ROCm. More "
183-
"generally, MathTransformPass should do the right things for each "
184-
"target.");
185-
}
186-
}
187-
};
188-
189167
class MathTransformPass final
190168
: public impl::MathTransformPassBase<MathTransformPass> {
191169
public:
192170
using Base::Base;
193171

194172
void runOnOperation() override {
195-
static DeprecationWarningForNativeMathPrecision warning;
196-
197173
RewritePatternSet patterns(&getContext());
198174
auto target = IREE::HAL::ExecutableTargetAttr::lookup(getOperation());
199175
if (!target) {

0 commit comments

Comments
 (0)