Free buffers synchronously if async caching is disabled. (iree-org#21668)

AWoloszyn · keshavvinayak01 · commit a632a2e167a8 · 2025-09-04T18:04:06.000Z
Signed-off-by: Andrew Woloszyn &lt;andrew.woloszyn@gmail.com&gt;
Signed-off-by: keshavvinayak01 &lt;keshavvinayakjha@gmail.com&gt;
diff --git a/runtime/src/iree/hal/drivers/hip/hip_device.c b/runtime/src/iree/hal/drivers/hip/hip_device.c
@@ -1006,7 +1006,11 @@ static void iree_hal_hip_async_buffer_release(
   iree_hal_hip_device_t* device = (iree_hal_hip_device_t*)user_data;
   void* ptr = iree_hal_hip_buffer_device_pointer(buffer);
   if (ptr) {
-    iree_hal_hip_allocator_free_async(device->device_allocator, buffer);
+    if (device->params.async_caching) {
+      iree_hal_hip_allocator_free_async(device->device_allocator, buffer);
+    } else {
+      iree_hal_hip_allocator_free_sync(device->device_allocator, buffer);
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1006,7 +1006,11 @@ static void iree_hal_hip_async_buffer_release(`
`1006`	`1006`	`iree_hal_hip_device_t* device = (iree_hal_hip_device_t*)user_data;`
`1007`	`1007`	`void* ptr = iree_hal_hip_buffer_device_pointer(buffer);`
`1008`	`1008`	`if (ptr) {`
`1009`		`- iree_hal_hip_allocator_free_async(device->device_allocator, buffer);`
	`1009`	`+ if (device->params.async_caching) {`
	`1010`	`+ iree_hal_hip_allocator_free_async(device->device_allocator, buffer);`
	`1011`	`+ } else {`
	`1012`	`+ iree_hal_hip_allocator_free_sync(device->device_allocator, buffer);`
	`1013`	`+ }`
`1010`	`1014`	`}`
`1011`	`1015`	`}`
`1012`	`1016`