Skip to content

Commit 5f68d6a

Browse files
committed
test(scheduler): Fix AbstractSchedulerWorkerGroupTest
1 parent e682ffe commit 5f68d6a

File tree

4 files changed

+33
-16
lines changed

4 files changed

+33
-16
lines changed

scheduler/src/test/java/io/kestra/scheduler/Fixtures.java

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,28 @@
1313
import java.util.function.Function;
1414

1515
public interface Fixtures {
16-
16+
1717
String TEST_TENANT = "tenant";
1818
String TEST_NAMESPACE = "io.kestra.unittest";
1919
String TEST_FLOW_ID = "test";
2020
String TEST_TRIGGER_ID = "trigger";
21-
21+
2222
static TriggerId triggerId() {
2323
return triggerId(TEST_TRIGGER_ID);
2424
}
25-
25+
2626
static TriggerId triggerId(String triggerId) {
2727
return TriggerId.of(TEST_TENANT, TEST_NAMESPACE, TEST_FLOW_ID, triggerId);
2828
}
29-
29+
3030
static FlowWithSource defaultFlow() {
3131
return defaultFlow(Schedule.ScheduleBuilder::build);
3232
}
33-
33+
3434
static FlowWithSource defaultFlow(Function<Schedule.ScheduleBuilder<?, ?>, Schedule> builder) {
3535
return flowWithSchedulePT15M("Europe/Paris", builder);
3636
}
37-
37+
3838
static FlowWithSource flowWithTrigger(AbstractTrigger trigger) {
3939
return FlowWithSource.builder()
4040
.tenantId(TEST_TENANT)
@@ -45,34 +45,45 @@ static FlowWithSource flowWithTrigger(AbstractTrigger trigger) {
4545
.triggers(List.of(trigger))
4646
.build();
4747
}
48-
48+
49+
static FlowWithSource flowWithTrigger(AbstractTrigger trigger, String flowId) {
50+
return FlowWithSource.builder()
51+
.tenantId(TEST_TENANT)
52+
.id(flowId)
53+
.revision(0)
54+
.namespace(TEST_NAMESPACE)
55+
.tasks(List.of(Return.builder().id("return").type(Return.class.getName()).build()))
56+
.triggers(List.of(trigger))
57+
.build();
58+
}
59+
4960
static FlowWithSource flowWithSchedulePT15M(String timeZone) {
5061
return flowWithSchedulePT15M(timeZone, Schedule.ScheduleBuilder::build);
5162
}
52-
63+
5364
static FlowWithSource flowWithScheduleOnDate(String timeZone, List<ZonedDateTime> dates) {
5465
return flowWithScheduleOnDate(timeZone, dates, ScheduleOnDates.ScheduleOnDatesBuilder::build);
5566
}
56-
67+
5768
static FlowWithSource flowWithScheduleOnDate(String timeZone, List<ZonedDateTime> dates, Function<ScheduleOnDates.ScheduleOnDatesBuilder<?, ?>, ScheduleOnDates> builder) {
58-
69+
5970
ScheduleOnDates.ScheduleOnDatesBuilder<?, ?> schedule = ScheduleOnDates.builder()
6071
.id(TEST_TRIGGER_ID)
6172
.type(ScheduleOnDates.class.getName())
6273
.dates(Property.ofValue(dates))
6374
.timezone(timeZone);
64-
75+
6576
return flowWithTrigger(builder.apply(schedule));
6677
}
67-
78+
6879
static FlowWithSource flowWithSchedulePT15M(String timeZone, Function<Schedule.ScheduleBuilder<?, ?>, Schedule> builder) {
69-
80+
7081
Schedule.ScheduleBuilder<?, ?> schedule = Schedule.builder()
7182
.id(TEST_TRIGGER_ID)
7283
.type(Schedule.class.getName())
7384
.cron("*/15 * * * *")
7485
.timezone(timeZone);
75-
86+
7687
return flowWithTrigger(builder.apply(schedule));
7788
}
7889
}

tests/src/main/java/io/kestra/core/junit/annotations/KestraTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828

2929
boolean startWorker() default true;
3030

31+
boolean startWorkerController() default true;
32+
3133
Class<?> application() default void.class;
3234

3335
String[] environments() default {};

tests/src/main/java/io/kestra/core/junit/extensions/KestraTestExtension.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ public void beforeAll(ExtensionContext extensionContext) throws Exception {
5757
if (!runner.isRunning()){
5858
runner.setSchedulerEnabled(kestraTest.startScheduler());
5959
runner.setWorkerEnabled(kestraTest.startWorker());
60+
runner.setWorkerControllerEnabled(kestraTest.startWorkerController());
6061
runner.run();
6162
}
6263
}

tests/src/main/java/io/kestra/core/runners/TestRunner.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public class TestRunner implements Runnable, AutoCloseable {
2727
@Setter private int workerThread = Math.max(3, Runtime.getRuntime().availableProcessors()) * 4;
2828
@Setter private boolean schedulerEnabled = true;
2929
@Setter private boolean workerEnabled = true;
30+
@Setter private boolean workerControllerEnabled = true;
3031

3132
@Inject
3233
private ExecutorsUtils executorsUtils;
@@ -52,11 +53,13 @@ public void run() {
5253
servers.add(executor);
5354
poolExecutor.execute(executor);
5455

55-
if (workerEnabled) {
56+
if (workerControllerEnabled) {
5657
Controller controller = applicationContext.getBean(Controller.class);
5758
poolExecutor.execute(controller::start);
5859
servers.add(controller);
59-
60+
}
61+
62+
if (workerEnabled) {
6063
Worker worker = applicationContext.getBean(Worker.class);
6164
poolExecutor.execute(() -> worker.start(workerThread, null));
6265
servers.add(worker);

0 commit comments

Comments
 (0)