Skip to content

feat(core): implement Role.NAME filter.#14808

Merged
ammeek merged 5 commits intodevelopfrom
feat/role-name-filter
Mar 4, 2026
Merged

feat(core): implement Role.NAME filter.#14808
ammeek merged 5 commits intodevelopfrom
feat/role-name-filter

Conversation

@ammeek
Copy link
Contributor

@ammeek ammeek commented Feb 25, 2026

✨ Description

What does this PR change?
Add Role.NAME filter

🔗 Related Issue

relates to kestra-io/kestra-ee#6256

🛠️ Backend Checklist

  • Code compiles successfully and passes all checks
  • All unit and integration tests pass

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

🐋 Docker image

ghcr.io/kestra-io/kestra-pr:14808
docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:14808 server local

🧪 Java Unit Tests

TestsPassed ✅Skipped ⚠️FailedTime ⏱
Java Tests Report3971 ran3958 ✅13 ⚠️0 ❌42m 57s 300ms

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Tests report quick summary:

success ✅ > tests: 3971, success: 3958, skipped: 13, failed: 0

unfold for details
Project Status Success Skipped Failed
cli success ✅ 80 0 0
core success ✅ 1919 0 0
executor success ✅ 4 0 0
jdbc success ✅ 11 0 0
jdbc-h2 success ✅ 473 0 0
jdbc-mysql success ✅ 476 0 0
jdbc-postgres success ✅ 476 0 0
processor success ✅ 7 0 0
runner-memory success ✅ 1 0 0
scheduler success ✅ 23 0 0
script success ✅ 12 0 0
storage-local success ✅ 64 0 0
webserver success ✅ 421 0 0
worker success ✅ 4 0 0

Develocity build scan: https://develocity.kestra.io/s/lq35k45amzrpk

Copy link
Contributor

@AcevedoR AcevedoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt check but I suppose tests are in EE ?

@ammeek
Copy link
Contributor Author

ammeek commented Mar 4, 2026

@AcevedoR This Pr is currently missing the required filter tests due to the large refactor in this PR. Once that Pr is merged I'll bring the changes back into this PR and add the tests. I've done this to avoid merge conflicts with the large refactor. As you said in the other PR probably best to avoid this in future.

@AcevedoR AcevedoR self-requested a review March 4, 2026 13:52
@ammeek ammeek merged commit f0e1051 into develop Mar 4, 2026
14 checks passed
@ammeek ammeek deleted the feat/role-name-filter branch March 4, 2026 14:58
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants