-
-
Notifications
You must be signed in to change notification settings - Fork 28
Labels
bugneeds:testsThis issue needs tests. Desperately.This issue needs tests. Desperately.priority:highThis issue violates the specificationThis issue violates the specificationscope:calculationThis issue relates to the calculation logicThis issue relates to the calculation logic
Description
Why:
Wrong prioritization of up/down props.
Environment:
- atomic-layout version:
0.6.2
Steps to reproduce:
Steps to reproduce the behavior:
<Composition
templateCols="200px auto"
templateColsSmDown="400px 1fr"
/>On xs screens the grid-template-columns value will still be 400px 1fr (originating from templateColsSmDown.
Expected behavior:
Props with "down" behavior indeed fill any gaps below them, but when any explicit prop is met (i.e. templateCols for xs), this explicit prop must take the highest priority.
Roadmap
- Fix
- Add covering test
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugneeds:testsThis issue needs tests. Desperately.This issue needs tests. Desperately.priority:highThis issue violates the specificationThis issue violates the specificationscope:calculationThis issue relates to the calculation logicThis issue relates to the calculation logic