Skip to content

Commit 1144418

Browse files
committed
Refactor test fixtures and update search item kind checks for consistency
1 parent 863e1fc commit 1144418

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/CompaniesHouse/JsonConverters/SearchItemConverter.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ public class SearchItemConverter : JsonCreationConverter<SearchItem>
1313
protected override SearchItem Create(Type objectType, JObject jObject)
1414
{
1515
var kind = jObject.Value<string>("kind");
16-
if (kind == "searchresults#company")
16+
if (kind is "searchresults#company" or "search-results#company")
1717
{
1818
return new Company();
1919
}
20-
else if (kind == "searchresults#officer")
20+
else if (kind is "searchresults#officer")
2121
{
2222
return new Officer();
2323
}
24-
else if (kind == "searchresults#disqualified-officer")
24+
else if (kind is "searchresults#disqualified-officer")
2525
{
2626
return new DisqualifiedOfficer();
2727
}

tests/CompaniesHouse.IntegrationTests/Tests/SearchingTests/CompanySearchAdvancedTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace CompaniesHouse.IntegrationTests.Tests.SearchingTests
88
{
9-
[TestFixture("brighouse computers")]
9+
[TestFixture("brighouse")]
1010
[TestFixture("British Gas")]
1111
[TestFixture("Bay Horse")]
1212
public class CompanySearchAdvancedTests

tests/CompaniesHouse.IntegrationTests/Tests/SearchingTests/CompanySearchTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ namespace CompaniesHouse.IntegrationTests.Tests.SearchingTests
99
[TestFixture("brighouse computers")]
1010
[TestFixture("British Gas")]
1111
[TestFixture("Bay Horse")]
12-
1312
public class CompanySearchTests
1413
{
1514
private readonly string _query;

0 commit comments

Comments
 (0)