Merge pull request #62 from immerrr/fix-redirect-location-scheme-for-secure-server

httpbin_secure: fix redirect Location to have "https://" scheme

Author: kevin1024

pytest_httpbin/serve.py

@@ -69,6 +69,7 @@ def finish_request(self, request, client_address):
                 server_side=True,
                 suppress_ragged_eofs=False,
             )
+            self.base_environ['HTTPS'] = 'yes'
             self.RequestHandlerClass(ssock, client_address, self)
         except Exception as e:
             print("pytest-httpbin server hit an exception serving request: %s" % e)

tests/test_server.py

@@ -92,3 +92,14 @@ def test_fixed_port_environment_variables(protocol):
             del os.environ[envvar]
         else:
             os.environ[envvar] = envvar_original
+
+
+def test_redirect_location_is_https_for_secure_server(httpbin_secure):
+    assert httpbin_secure.url.startswith('https://')
+    response = requests.get(
+        httpbin_secure + "/redirect-to?url=/html",
+        allow_redirects=False
+    )
+    assert response.status_code == 302
+    assert response.headers.get('Location')
+    assert response.headers['Location'].startswith('https://')