bug: fixes #221 wrong latest version (#222)

* bug: fixes #221 wrong latest version

* ci: golang lint vup to latest for 1.25

* ci: golang lint vup to latest for 1.25

* ci: golang lint vup to latest for 1.25

* ci: golang lint vet

* ci: fix tests new semantics

* ci: fix tests new semantics

Author: kevincobain2000

.github/workflows/golangci-lint.yml

@@ -1,8 +1,5 @@
 name: golangci-lint
 on:
-  push:
-    branches:
-      - '**'
   pull_request:
     branches:
       - '**'
@@ -21,7 +18,5 @@ jobs:
         uses: kevincobain2000/action-gobrew@v2
         with:
           version: latest
-      -
-        uses: golangci/golangci-lint-action@v6
-        with:
-          version: latest
+      - run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0
+      - run: golangci-lint run ./...

.golangci.yaml

@@ -1,24 +1,37 @@
+version: "2"
 linters:
-  # Disable all linters.
-  # Default: false
-  disable-all: true
-  # Enable specific linter
-  # https://golangci-lint.run/usage/linters/#enabled-by-default
+  default: none
   enable:
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
+    - copyloopvar
     - dupl
+    - errcheck
     - errorlint
-    - copyloopvar
     - goconst
     - gocritic
     - gocyclo
     - goprintffuncname
     - gosec
+    - govet
+    - ineffassign
     - prealloc
     - revive
-    - stylecheck
+    - staticcheck
     - whitespace
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

go.mod

@@ -1,12 +1,13 @@
 module github.com/kevincobain2000/gobrew
 
-go 1.22.0
+go 1.25.1
 
 require (
 	github.com/Masterminds/semver v1.5.0
 	github.com/c4milo/unpackit v1.0.0
 	github.com/gookit/color v1.5.4
 	github.com/schollz/progressbar/v3 v3.14.1
+	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.4
 )
 
@@ -19,7 +20,6 @@ require (
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
-	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/ulikunitz/xz v0.5.11 // indirect
 	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
 	golang.org/x/sys v0.17.0 // indirect

gobrew.go

@@ -108,7 +108,7 @@ func (gb *GoBrew) Interactive(ask bool) {
 	modVersion := NoneVersion
 	if gb.hasModFile() {
 		modVersion = gb.getModVersion()
-		modVersion = extractMajorVersion(modVersion)
+		// modVersion = extractMajorVersion(modVersion)
 	}
 
 	fmt.Println()
@@ -135,7 +135,7 @@ func (gb *GoBrew) Interactive(ask bool) {
 	}
 
 	if modVersion != NoneVersion && latestMajorVersion != modVersion {
-		label := " " + color.FgYellow.Render("\t⚠️  not latest")
+		label := " " + color.FgYellow.Render("\t⚠️ not latest")
 		color.Successln("📄 go.mod Version", "   .......", modVersion+label)
 	} else {
 		color.Successln("📄 go.mod Version", "   .......", modVersion)
@@ -156,7 +156,7 @@ func (gb *GoBrew) Interactive(ask bool) {
 	}
 
 	if modVersion != NoneVersion && currentMajorVersion != modVersion {
-		color.Warnf("⚠️  GO Installed Version (%s) and go.mod Version (%s) are different.\n", currentMajorVersion, modVersion)
+		color.Warnf("⚠️ GO Installed Version (%s) and go.mod Version (%s) are different.\n", currentMajorVersion, modVersion)
 		fmt.Println("   Please consider updating your go.mod file")
 		c := true
 		if ask {
@@ -169,7 +169,7 @@ func (gb *GoBrew) Interactive(ask bool) {
 	}
 
 	if currentVersion != latestVersion {
-		color.Warnf("⚠️  GO Installed Version (%s) and GO Latest Version (%s) are different.\n", currentVersion, latestVersion)
+		color.Warnf("⚠️ GO Installed Version (%s) and GO Latest Version (%s) are different.\n", currentVersion, latestVersion)
 		c := true
 		if ask {
 			c = askForConfirmation("🤔 Do you want to update GO to latest version (" + latestVersion + ")?")
@@ -321,9 +321,17 @@ func (gb *GoBrew) Install(version string) string {
 		color.Errorln("[Error] No version provided")
 		os.Exit(1)
 	}
+	// if version has 2 dots, then remove the @latest or @dev-latest
+	if strings.Count(version, ".") == 2 {
+		if strings.HasSuffix(version, "@latest") || strings.HasSuffix(version, "@dev-latest") {
+			version = strings.TrimSuffix(version, "@latest")
+			version = strings.TrimSuffix(version, "@dev-latest")
+		}
+	}
+	tmpVersion := version
 	version = gb.judgeVersion(version)
 	if version == NoneVersion {
-		color.Errorln("[Error] Version non exists")
+		color.Errorln("[Error] Version", tmpVersion, "does not exists")
 		os.Exit(1)
 	}
 	if gb.existsVersion(version) {

helpers.go

@@ -26,15 +26,28 @@ import (
 
 func (gb *GoBrew) getLatestVersion() string {
 	getGolangVersions := gb.getGolangVersions()
-	// loop through reverse and ignore beta and rc versions to get latest version
-	for i := len(getGolangVersions) - 1; i >= 0; i-- {
+
+	// Filter out beta and rc versions and create semantic versions
+	var validVersions []*semver.Version
+	for _, version := range getGolangVersions {
 		r := regexp.MustCompile("beta.*|rc.*")
-		matches := r.FindAllString(getGolangVersions[i], -1)
+		matches := r.FindAllString(version, -1)
 		if len(matches) == 0 {
-			return getGolangVersions[i]
+			if v, err := semver.NewVersion(version); err == nil {
+				validVersions = append(validVersions, v)
+			}
 		}
 	}
-	return ""
+
+	if len(validVersions) == 0 {
+		return ""
+	}
+
+	// Sort semantic versions
+	sort.Sort(semver.Collection(validVersions))
+
+	// Return the latest version (last in sorted order)
+	return validVersions[len(validVersions)-1].String()
 }
 
 func (gb *GoBrew) getArch() string {
@@ -503,7 +516,7 @@ func askForConfirmation(s string) bool {
 	reader := bufio.NewReader(os.Stdin)
 
 	for {
-		color.Successf(s) // nolint:govet
+		color.Successln(s)
 		fmt.Print(" [y/n]: ")
 
 		response, err := reader.ReadString('\n')

helpers_test.go

@@ -36,11 +36,11 @@ func TestJudgeVersion(t *testing.T) {
 		},
 		{
 			version:     "1.18@latest",
-			wantVersion: "1.18.10",
+			wantVersion: "1.18.9",
 		},
 		{
 			version:     "1.18@dev-latest",
-			wantVersion: "1.18.10",
+			wantVersion: "1.18.9",
 		},
 		{
 			version:     "go1.18",