correctly use rc

Author: kevinjqliu

.github/workflows/python-release.yml

@@ -22,35 +22,36 @@ name: "Python Build Release Candidate"
 on:
   push:
     tags:
-      # Trigger this workflow when tag follows the versioning format: <major>.<minor>.<patch>rc<release_candidate>
-      # Example valid tags: 0.8.1rc1, 1.0.0rc2
-      - '[0-9]+.[0-9]+.[0-9]+rc[0-9]+'
+      # Trigger this workflow when tag follows the versioning format: pyiceberg-<major>.<minor>.<patch>rc<release_candidate>
+      # Example valid tags: pyiceberg-0.8.0rc2, pyiceberg-1.0.0rc1
+      - 'pyiceberg-[0-9]+.[0-9]+.[0-9]+rc[0-9]+'
   workflow_dispatch:
     inputs:
       version:
         description: 'Version (e.g., 0.8.0)'
         type: string
         required: true
       rc:
-        description: 'Release Candidate (RC) (e.g., rc1)'
-        type: string
+        description: 'Release Candidate (RC) (e.g., 1)'
+        type: number
         required: true
 
 jobs:
   validate-inputs:
     runs-on: ubuntu-latest
     outputs:
-      VERSION: ${{ steps.validate-inputs.outputs.VERSION }}
-      RC: ${{ steps.validate-inputs.outputs.RC }}
+      VERSION: ${{ steps.validate-inputs.outputs.VERSION }} # e.g. 0.8.0
+      RC: ${{ steps.validate-inputs.outputs.RC }} # e.g. 1
     steps:
       - name: Validate and Extract Version and RC
         id: validate-inputs
         run: |
           if [ "$GITHUB_EVENT_NAME" = "push" ]; then
             echo "Workflow triggered by tag push."
             TAG=${GITHUB_REF#refs/tags/} # Extract the tag name
-            VERSION=${TAG%rc*} # Extract version by removing everything after "rc"
-            RC=${TAG#*rc} # Extract RC by removing everything before "rc"
+            VERSION_AND_RC=${TAG#pyiceberg-} # Remove the 'pyiceberg-' prefix
+            VERSION=${VERSION_AND_RC%rc*} # Extract VERSION by removing everything after 'rc'
+            RC=${VERSION_AND_RC#*rc} # Extract RC by keeping everything after 'rc'
 
             if [[ -z "$VERSION" || -z "$RC" ]]; then
               echo "Error: Unable to parse VERSION or RC from tag ($TAG). Ensure the tag format is correct."
@@ -63,15 +64,11 @@ jobs:
 
             # Validate version (e.g., 1.0.0)
             if [[ ! "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
-              echo "Error: version ($VERSION) must be in the format <number>.<number>.<number>"
+              echo "Error: version ($VERSION) must be in the format: <number>.<number>.<number>"
               exit 1
             fi
 
-            # Validate rc (e.g., rc1)
-            if [[ ! "$RC" =~ ^rc[0-9]+$ ]]; then
-              echo "Error: rc ($RC) must be in the format rc<number>"
-              exit 1
-            fi
+            # RC is already validated as a number via workflow_dispatch inputs
           fi
 
           # Export variables for future steps
@@ -80,8 +77,8 @@ jobs:
 
       - name: Display Extracted Version and RC
         run: |
-          echo "Using Version: $VERSION"
-          echo "Using RC: $RC"
+          echo "Using Version: ${{ steps.validate-inputs.outputs.VERSION }}"
+          echo "Using RC: ${{ steps.validate-inputs.outputs.RC }}"
 
   validate-library-version:
     runs-on: ubuntu-latest