Skip to content

Commit ab62ee4

Browse files
committed
feat: updates DefaultLogger per GitHub issue thread
Signed-off-by: Kevin Long <[email protected]>
1 parent 730a57d commit ab62ee4

File tree

5 files changed

+23
-27
lines changed

5 files changed

+23
-27
lines changed

packages/shared/src/hooks/logging-hook.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { BaseHook } from './hook';
33
import type { BeforeHookContext, HookContext, HookHints } from './hooks';
44
import type { FlagValue, EvaluationDetails } from '../evaluation';
55

6-
import { VerboseLogger, SafeLogger } from '../logger';
6+
import { DefaultLogger, SafeLogger } from '../logger';
77

88
type LoggerPayload = Record<string, unknown>;
99

@@ -20,7 +20,7 @@ const VALUE_KEY = 'value';
2020

2121
export class LoggingHook implements BaseHook {
2222
readonly includeEvaluationContext: boolean = false;
23-
readonly logger = new SafeLogger(new VerboseLogger());
23+
readonly logger = new SafeLogger(new DefaultLogger(true, true));
2424

2525
constructor(includeEvaluationContext: boolean = false) {
2626
this.includeEvaluationContext = !!includeEvaluationContext;

packages/shared/src/logger/default-logger.ts

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@
33
import type { Logger } from './logger';
44

55
export class DefaultLogger implements Logger {
6+
7+
private readonly showInfo : boolean = false;
8+
private readonly showDebug : boolean = false;
9+
10+
constructor(showInfo: boolean = false, showDebug: boolean = false){
11+
this.showInfo = showInfo;
12+
this.showDebug = showDebug;
13+
}
14+
615
error(...args: unknown[]): void {
716
console.error(...args);
817
}
@@ -11,7 +20,15 @@ export class DefaultLogger implements Logger {
1120
console.warn(...args);
1221
}
1322

14-
info(): void {}
23+
info(...args: unknown[]): void {
24+
if(this.showInfo) {
25+
console.info(...args);
26+
}
27+
}
1528

16-
debug(): void {}
29+
debug(...args: unknown[]): void {
30+
if(this.showDebug) {
31+
console.debug(...args);
32+
}
33+
}
1734
}
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
export * from './logger';
22
export * from './default-logger';
33
export * from './safe-logger';
4-
export * from './verbose-logger';

packages/shared/src/logger/verbose-logger.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/shared/test/logger-hook.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { GeneralError } from '../src/errors';
22
import type { HookContext } from '../src/hooks/hooks';
33
import { LoggingHook } from '../src/hooks/logging-hook';
4-
import { SafeLogger } from '../src/logger';
5-
import { VerboseLogger } from '../src/logger';
4+
import { DefaultLogger, SafeLogger } from '../src/logger';
65

76
describe('LoggingHook', () => {
87
const FLAG_KEY = 'some-key';
@@ -22,7 +21,7 @@ describe('LoggingHook', () => {
2221
const ERROR_MESSAGE_KEY = 'error_message';
2322

2423
let hookContext: HookContext;
25-
const logger : SafeLogger = new SafeLogger(new VerboseLogger());
24+
const logger : SafeLogger = new SafeLogger(new DefaultLogger(true, true));
2625

2726
beforeEach(() => {
2827
const mockProviderMetaData = { name: PROVIDER_NAME };

0 commit comments

Comments
 (0)