Remove workaround for yargs/yargs#755

This was fixed in yargs 7.0.0 2 years ago, but the issue had not been
closed.

Signed-off-by: Kevin Locke <[email protected]>

Author: kevinoid

bin/cmd.js

@@ -12,30 +12,6 @@ const Yargs = require('yargs/yargs');
 const packageJson = require('../package.json');
 const modulename = require('..');
 
-/** Calls <code>yargs.parse</code> and passes any thrown errors to the callback.
- * Workaround for https://github.com/yargs/yargs/issues/755
- * @private
- */
-function parseYargs(yargs, args, callback) {
-  // Since yargs doesn't nextTick its callback, this function must be careful
-  // that exceptions thrown from callback (which propagate through yargs.parse)
-  // are not caught and passed to a second invocation of callback.
-  let called = false;
-  try {
-    yargs.parse(args, function(...cbargs) {
-      called = true;
-      return callback.apply(this, cbargs);
-    });
-  } catch (err) {
-    if (called) {
-      // err was thrown after or by callback.  Let it propagate.
-      throw err;
-    } else {
-      callback(err);
-    }
-  }
-}
-
 /** Options for command entry points.
  *
  * @typedef {{
@@ -114,7 +90,7 @@ function modulenameCmd(args, options, callback) {
     .version(`${packageJson.name} ${packageJson.version}`)
     .alias('version', 'V')
     .strict();
-  parseYargs(yargs, args, (err, argOpts, output) => {
+  yargs.parse(args, (err, argOpts, output) => {
     if (err) {
       if (output) {
         options.stderr.write(`${output}\n`);