Skip to content

Commit 98a184d

Browse files
committed
Don't use package-lock.json for CI
Continuous Integration builds should use the latest version of dependencies, both to ensure the package is currently installable for downstream users (where package-lock.json isn't used) and to ensure the code works with the latest version of its dependencies. Signed-off-by: Kevin Locke <[email protected]>
1 parent 5731a72 commit 98a184d

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

.travis.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ node_js:
1717

1818
sudo: false
1919

20+
install:
21+
# Ignore package-lock.json. This is done for a few reasons:
22+
# - To test against current versions of dependencies.
23+
# - To test installability for dependents (doesn't use package-lock.json).
24+
- rm -f package-lock.json
25+
- npm install
26+
2027
script:
2128
- npm run test-cov
2229

appveyor.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ environment:
2020
install:
2121
- ps: Install-Product node $env:nodejs_version
2222
- npm -g install "npm@%npm_version%"
23+
# Ignore package-lock.json. This is done for a few reasons:
24+
# - To test against current versions of dependencies.
25+
# - To test installability for dependents (doesn't use package-lock.json).
26+
- if exist package-lock.json del package-lock.json
2327
- npm install
2428

2529
test_script:

0 commit comments

Comments
 (0)