fix(policychecks): Update Policy Checks to use profile selected by AWS Toolkits instead of always default

Author: kevluu-aws

packages/core/src/awsService/accessanalyzer/vue/iamPolicyChecks.ts

@@ -179,7 +179,9 @@ export class IamPolicyChecksWebview extends VueWebview {
                             documentType,
                             inputPolicyType: policyType ? policyType : 'None',
                         })
-                        this.client.config.credentials = new SharedIniFileCredentials() // We need to detect changes in the user's credentials
+                        this.client.config.credentials = new SharedIniFileCredentials({
+                            profile: `${getProfileName()}`,
+                        }) // We need to detect changes in the user's credentials
                         this.client.validatePolicy(
                             {
                                 policyDocument: IamPolicyChecksWebview.editedDocument,
@@ -276,6 +278,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${this.region}`,
                         '--config',
                         `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     this.executeValidatePolicyCommand({
                         command,
@@ -296,7 +300,15 @@ export class IamPolicyChecksWebview extends VueWebview {
             case 'CloudFormation': {
                 if (isCloudFormationTemplate(document)) {
                     const command = 'cfn-policy-validator'
-                    const args = ['validate', '--template-path', `${document}`, '--region', `${this.region}`]
+                    const args = [
+                        'validate',
+                        '--template-path',
+                        `${document}`,
+                        '--region',
+                        `${this.region}`,
+                        '--profile',
+                        `${getProfileName()}`,
+                    ]
                     if (cfnParameterPath !== '') {
                         args.push('--template-configuration-file', `${cfnParameterPath}`)
                     }
@@ -356,6 +368,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${tempFilePath}`,
                         '--reference-policy-type',
                         `${policyType}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     this.executeCustomPolicyChecksCommand({
                         command,
@@ -387,6 +401,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${tempFilePath}`,
                         '--reference-policy-type',
                         `${policyType}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     if (cfnParameterPath !== '') {
                         args.push('--template-configuration-file', `${cfnParameterPath}`)
@@ -447,6 +463,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${this.region}`,
                         '--config',
                         `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     if (actions !== '') {
                         args.push('--actions', `${actions}`)
@@ -479,6 +497,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${document}`,
                         '--region',
                         `${this.region}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     if (actions !== '') {
                         args.push('--actions', `${actions}`)
@@ -524,6 +544,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${this.region}`,
                         '--config',
                         `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     this.executeCustomPolicyChecksCommand({
                         command,
@@ -550,6 +572,8 @@ export class IamPolicyChecksWebview extends VueWebview {
                         `${document}`,
                         '--region',
                         `${this.region}`,
+                        '--profile',
+                        `${getProfileName()}`,
                     ]
                     if (cfnParameterPath !== '') {
                         args.push('--template-configuration-file', `${cfnParameterPath}`)
@@ -919,6 +943,11 @@ export function isJsonPolicyLanguage(document: string) {
     return policyLanguageFileTypes.some((t) => document.endsWith(t))
 }
 
+export function getProfileName(): string | undefined {
+    // We neeed to split the name on 'profile:' to extract the correct profile name
+    return globals.awsContext.getCredentialProfileName()?.split('profile:')[1]
+}
+
 export class PolicyChecksError extends ToolkitError {
     constructor(message: string, code: PolicyChecksErrorCode) {
         super(message, { code })

packages/core/src/test/awsService/accessanalyzer/iamPolicyChecks.test.ts

@@ -155,6 +155,8 @@ describe('validatePolicy', function () {
                 'us-east-1',
                 '--config',
                 `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`,
+                '--profile',
+                'undefined',
             ],
             cfnParameterPathExists: false,
             documentType,
@@ -182,6 +184,8 @@ describe('validatePolicy', function () {
                 'us-east-1',
                 '--template-configuration-file',
                 cfnParameterPath,
+                '--profile',
+                'undefined',
             ],
             cfnParameterPathExists: true,
             documentType,
@@ -453,6 +457,8 @@ describe('customChecks', function () {
                     'action1action2',
                     '--resources',
                     'resource1resource2',
+                    '--profile',
+                    'undefined',
                 ],
                 cfnParameterPathExists: !!cfnParameterPath,
                 documentType,
@@ -492,6 +498,8 @@ describe('customChecks', function () {
                     'resource1resource2',
                     '--template-configuration-file',
                     cfnParameterPath,
+                    '--profile',
+                    'undefined',
                 ],
                 cfnParameterPathExists: !!cfnParameterPath,
                 documentType,
@@ -548,6 +556,8 @@ describe('customChecks', function () {
                     'us-east-1',
                     '--config',
                     `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`,
+                    '--profile',
+                    'undefined',
                 ],
                 cfnParameterPathExists: !!cfnParameterPath,
                 documentType,
@@ -581,6 +591,8 @@ describe('customChecks', function () {
                     'us-east-1',
                     '--template-configuration-file',
                     cfnParameterPath,
+                    '--profile',
+                    'undefined',
                 ],
                 cfnParameterPathExists: !!cfnParameterPath,
                 documentType,