feat(notifications): enable notifications for all users (aws#6071)

- Removes feature flag
- Slightly adjusts toolkit_invokeAction telemetry to not use button
string, instead we use action enums.

---

<!--- REMINDER: Ensure that your PR meets the guidelines in
CONTRIBUTING.md -->

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

Author: hayemaxi

packages/amazonq/.changes/next-release/Feature-77884869-72ad-4ee0-986e-62cc1ca8e746.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "Notifications: Support for delivering critical alerts and product updates"
+}

packages/core/src/notifications/activation.ts

@@ -4,7 +4,6 @@
  */
 
 import * as vscode from 'vscode'
-import { DevSettings } from '../shared/settings'
 import { NotificationsController } from './controller'
 import { NotificationsNode } from './panelNode'
 import { RuleEngine, getRuleContext } from './rules'
@@ -30,11 +29,6 @@ export async function activate(
     initialState: AuthState,
     authStateFn: () => Promise<AuthState>
 ) {
-    // TODO: Currently gated behind feature-flag.
-    if (!DevSettings.instance.get('notifications', false)) {
-        return
-    }
-
     try {
         const panelNode = NotificationsNode.instance
         panelNode.registerView(context)

packages/core/src/notifications/panelNode.ts

@@ -181,7 +181,11 @@ export class NotificationsNode implements TreeNode {
                 // Display read-only txt document
                 logger.verbose(`showing txt document for notification: ${notification.id} ...`)
                 await telemetry.toolkit_invokeAction.run(async () => {
-                    telemetry.record({ source: getNotificationTelemetryId(notification), action: onClickType })
+                    telemetry.record({
+                        id: getNotificationTelemetryId(notification),
+                        source: getNotificationTelemetryId(notification),
+                        action: onClickType,
+                    })
                     await readonlyDocument.show(
                         notification.uiRenderInstructions.content['en-US'].description,
                         `Notification: ${notification.id}`
@@ -225,11 +229,16 @@ export class NotificationsNode implements TreeNode {
             .showInformationMessage(title, { modal: isModal, detail }, ...buttonLabels)
             .then((response) => {
                 return telemetry.toolkit_invokeAction.run(async (span) => {
-                    span.record({ source: getNotificationTelemetryId(notification), action: response ?? 'OK' })
+                    span.record({
+                        id: getNotificationTelemetryId(notification),
+                        source: getNotificationTelemetryId(notification),
+                        action: response ?? 'OK',
+                    })
                     if (response) {
                         const selectedButton = buttons.find((actions) => actions.displayText['en-US'] === response)
                         // Different button options
                         if (selectedButton) {
+                            span.record({ action: selectedButton.type })
                             switch (selectedButton.type) {
                                 case 'openTextDocument':
                                     await readonlyDocument.show(

packages/toolkit/.changes/next-release/Feature-e62b5743-d746-4689-91dd-96d037d346fe.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "Notifications: Support for delivering critical alerts and product updates"
+}