Ignore implicit memberships in Requester.getAllTeams

zapu · zapu · commit 913c076c5665 · 2020-06-16T19:32:59.000+02:00
diff --git a/src/kssh/requester.go b/src/kssh/requester.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/keybase/bot-sshca/src/shared"
 	"github.com/keybase/go-keybase-chat-bot/kbchat"
+	"github.com/keybase/go-keybase-chat-bot/kbchat/types/keybase1"
 )
 
 type Requester struct {
@@ -94,7 +95,9 @@ func (r *Requester) getAllTeams() (teams []string, err error) {
 		return teams, err
 	}
 	for _, m := range memberships {
-		teams = append(teams, m.FqName)
+		if m.Role != keybase1.TeamRole_NONE {
+			teams = append(teams, m.FqName)
+		}
 	}
 	return teams, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`
`9`	`9`	`"github.com/keybase/bot-sshca/src/shared"`
`10`	`10`	`"github.com/keybase/go-keybase-chat-bot/kbchat"`
	`11`	`+ "github.com/keybase/go-keybase-chat-bot/kbchat/types/keybase1"`
`11`	`12`	`)`
`12`	`13`
`13`	`14`	`type Requester struct {`
`@@ -94,7 +95,9 @@ func (r *Requester) getAllTeams() (teams []string, err error) {`
`94`	`95`	`return teams, err`
`95`	`96`	`}`
`96`	`97`	`for _, m := range memberships {`
`97`		`- teams = append(teams, m.FqName)`
	`98`	`+ if m.Role != keybase1.TeamRole_NONE {`
	`99`	`+ teams = append(teams, m.FqName)`
	`100`	`+ }`
`98`	`101`	`}`
`99`	`102`	`return teams, nil`
`100`	`103`	`}`