Keyclock init sometimes does not resolve promise

[oleksiirugik]

Describe the bug

Hi guys,

I have electron app and in my application something like this:

  return this.keycloak.init({
     onLoad: 'check-sso' as KeycloakOnLoad,
     ...initOptions,
   });

and this promise will be never resolver or rejected, it's happening not so often, but anyway, is it possible to check this issue?

Version

26.2.3

Expected behavior

keyclock.init should resolved or rejected.

Actual behavior

keyclock.init sometimes stuck without any response.

How to Reproduce?

When use keyclock.logout.

Anything else?

No response

[jonkoops]

We'll need a bit more information to go on to be able to identify this bug. Can you provide a minimal and reproducible example that includes the minimal set of options that makes the problem reproducible? Please note that Electron is not an officially supported platform, so it might have quirks that cause this problem to manifest.

Please provide any additional details such as logs (console, and network) to see if something is going wrong in the background.

[oleksiirugik]

@jonkoops

just we do logout => login => logout => login and etc and sometimes it stacks.

I found a place in authSuccess where we have dead promise.

if (error) {
      if (prompt !== 'none') {
        if (oauth.error_description && oauth.error_description === 'authentication_expired') {
          await this.login(oauth.loginOptions)
        } else {
          const errorData = { error, error_description: oauth.error_description }
          this.onAuthError?.(errorData)
          throw errorData
        }
      }
      return
    } 

If I change to code below it would never stuck again.

if (error) {
      if (prompt === 'none') {
        // Silent check failed, not an error - just means user is not authenticated
        this.#logInfo('[KEYCLOAK] Silent authentication check failed: ' + error)
        return
      }
      if (oauth.error_description && oauth.error_description === 'authentication_expired') {
        await this.login(oauth.loginOptions)
        return
      }
      const errorData = { error, error_description: oauth.error_description }
      this.onAuthError?.(errorData)
      throw errorData
    } 

[jonkoops]

I am definitely a fan of an early return pattern for code readability, but the examples here both have the same exit points, so I don't see how this change should help. Perhaps your product has some instrumentation to allow capturing stack traces? That could give a hint of what is going wrong.