-
Notifications
You must be signed in to change notification settings - Fork 376
commit for referral addition #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
seems that the property fails on the 2 very oldest covered versions, gotta dig it |
|
the 'ldap referral' feature was merged on the end of 2023, guess its why this fails on v22 and v23: how can i skip this ? |
|
@demetthyl Thanks for your contribution! You can skip tests for older versions like this: terraform-provider-keycloak/provider/resource_keycloak_authentication_bindings_test.go Line 129 in 0afe0b2
Please also sign off your commit ( |
Signed-off-by: Guillaume <[email protected]>
Signed-off-by: Guillaume <[email protected]>
# Conflicts: # provider/resource_keycloak_ldap_user_federation_test.go
Thank you for your suggestion but i think that i am hitting a wall @sschu . This seems terribly unreasonable to skip most of the tests because they are invoked everywhere and this parameter didnt exist before v24, so the terraform plan sees a difference and fails tests I dont really know what the best approach is.. |
# Conflicts: # provider/resource_keycloak_ldap_user_federation_test.go
Signed-off-by: Guillaume <[email protected]>
|
ok i guess ive fixed my issue with the new ldap user config parameter, but im facing other test crashes on old versions, like:
Any idea why there are tests when inputs parameters are random generated ? |
|
Or this error: It is expected to generate this error, but test is still failure (in this keycloak version and not others...) |
Hello,
The object of this PR is to add the ability to configure the 'referral' property of the ldap user federation through the keycloak_ldap_user_federation Resource.