Skip to content

Commit 100167a

Browse files
sarroutbiansasaki
authored andcommitted
Align exp.backoff to current configuration format
Signed-off-by: Sergio Arroutbi <[email protected]>
1 parent 390ea3d commit 100167a

File tree

4 files changed

+31
-21
lines changed

4 files changed

+31
-21
lines changed

keylime-push-model-agent/src/main.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,13 @@ async fn run(args: &Args) -> Result<()> {
145145
ca_certificate: &args.ca_certificate,
146146
client_certificate: &args.certificate,
147147
ima_log_path: Some(config.ima_ml_path.as_str()),
148-
initial_delay_ms: config.expbackoff_initial_delay.unwrap_or(1000),
148+
initial_delay_ms: config
149+
.exponential_backoff_initial_delay
150+
.unwrap_or(1000),
149151
insecure: args.insecure,
150152
key: &args.key,
151-
max_delay_ms: config.expbackoff_max_delay,
152-
max_retries: config.expbackoff_max_retries.unwrap_or(5),
153+
max_delay_ms: config.exponential_backoff_max_delay,
154+
max_retries: config.exponential_backoff_max_retries.unwrap_or(5),
153155
timeout: args.timeout,
154156
uefi_log_path: Some(config.measuredboot_ml_path.as_str()),
155157
url: &negotiations_request_url,

keylime-push-model-agent/src/registration.rs

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,20 @@ pub async fn check_registration<T: PushModelConfigTrait>(
2525
fn get_retry_config<T: PushModelConfigTrait>(
2626
config: &T,
2727
) -> Option<RetryConfig> {
28-
if config.expbackoff_max_retries().is_none()
29-
&& config.expbackoff_initial_delay().is_none()
30-
&& config.expbackoff_max_delay().is_none()
28+
if config.exponential_backoff_max_retries().is_none()
29+
&& config.exponential_backoff_initial_delay().is_none()
30+
&& config.exponential_backoff_max_delay().is_none()
3131
{
3232
None
3333
} else {
3434
Some(RetryConfig {
35-
max_retries: config.expbackoff_max_retries().unwrap_or(0),
36-
initial_delay_ms: config.expbackoff_initial_delay().unwrap_or(0),
37-
max_delay_ms: *config.expbackoff_max_delay(),
35+
max_retries: config
36+
.exponential_backoff_max_retries()
37+
.unwrap_or(0),
38+
initial_delay_ms: config
39+
.exponential_backoff_initial_delay()
40+
.unwrap_or(0),
41+
max_delay_ms: *config.exponential_backoff_max_delay(),
3842
})
3943
}
4044
}
@@ -125,9 +129,9 @@ mod tests {
125129
agent_data_path: "".to_string(),
126130
disabled_signing_algorithms: vec![],
127131
};
128-
config.expbackoff_initial_delay = None;
129-
config.expbackoff_max_retries = None;
130-
config.expbackoff_max_delay = None;
132+
config.exponential_backoff_initial_delay = None;
133+
config.exponential_backoff_max_retries = None;
134+
config.exponential_backoff_max_delay = None;
131135

132136
let mut context_info = ContextInfo::new_from_str(alg_config)
133137
.expect("Failed to create context info from string");

keylime/src/config/base.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ pub struct AgentConfig {
114114
pub api_versions: String,
115115
pub disabled_signing_algorithms: Vec<String>,
116116
pub ek_handle: String,
117-
pub expbackoff_max_delay: Option<u64>,
118-
pub expbackoff_max_retries: Option<u32>,
119-
pub expbackoff_initial_delay: Option<u64>,
117+
pub exponential_backoff_max_delay: Option<u64>,
118+
pub exponential_backoff_max_retries: Option<u32>,
119+
pub exponential_backoff_initial_delay: Option<u64>,
120120
pub enable_iak_idevid: bool,
121121
pub iak_cert: String,
122122
pub iak_handle: String,
@@ -272,9 +272,13 @@ impl Default for AgentConfig {
272272
enable_revocation_notifications:
273273
DEFAULT_ENABLE_REVOCATION_NOTIFICATIONS,
274274
enc_keyname: DEFAULT_ENC_KEYNAME.to_string(),
275-
expbackoff_max_delay: Some(DEFAULT_EXP_BACKOFF_MAX_DELAY as u64),
276-
expbackoff_max_retries: Some(DEFAULT_EXP_BACKOFF_MAX_RETRIES),
277-
expbackoff_initial_delay: Some(
275+
exponential_backoff_max_delay: Some(
276+
DEFAULT_EXP_BACKOFF_MAX_DELAY as u64,
277+
),
278+
exponential_backoff_max_retries: Some(
279+
DEFAULT_EXP_BACKOFF_MAX_RETRIES,
280+
),
281+
exponential_backoff_initial_delay: Some(
278282
DEFAULT_EXP_BACKOFF_INITIAL_DELAY as u64,
279283
),
280284
extract_payload_zip: DEFAULT_EXTRACT_PAYLOAD_ZIP,

keylime/src/config/push_model.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ pub struct PushModelConfig {
3737
contact_ip: String,
3838
contact_port: u32,
3939
disabled_signing_algorithms: Vec<String>,
40-
expbackoff_max_delay: Option<u64>,
41-
expbackoff_max_retries: Option<u32>,
42-
expbackoff_initial_delay: Option<u64>,
40+
exponential_backoff_max_delay: Option<u64>,
41+
exponential_backoff_max_retries: Option<u32>,
42+
exponential_backoff_initial_delay: Option<u64>,
4343
enable_iak_idevid: bool,
4444
#[transform(using = override_default_ek_handle, error = OverrideError)]
4545
ek_handle: String,

0 commit comments

Comments
 (0)