Skip to content

Commit 430ad64

Browse files
committed
lib: Rename keylime_error.rs as error.rs
Add specific error type ContextInfoError for the context_info module and remove the usage of expect() to avoid panic. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
1 parent 78801af commit 430ad64

File tree

14 files changed

+134
-112
lines changed

14 files changed

+134
-112
lines changed

keylime-agent/src/common.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// Copyright 2021 Keylime Authors
33

4-
use keylime::keylime_error::{Error, Result};
5-
64
use crate::permissions;
75

8-
use keylime::algorithms::{
9-
EncryptionAlgorithm, HashAlgorithm, SignAlgorithm,
10-
};
116
use keylime::{
7+
algorithms::{EncryptionAlgorithm, HashAlgorithm, SignAlgorithm},
128
crypto::{hash, tss_pubkey_to_pem},
9+
error::{Error, Result},
1310
hash_ek, tpm,
1411
};
1512
use log::*;

keylime-agent/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ use keylime::{
5656
config,
5757
crypto::{self, x509::CertificateBuilder},
5858
device_id::{DeviceID, DeviceIDBuilder},
59+
error::{Error, Result},
5960
hash_ek,
6061
ima::MeasurementList,
61-
keylime_error::{Error, Result},
6262
list_parser::parse_list,
6363
permissions,
6464
registrar_client::RegistrarClientBuilder,

keylime-agent/src/revocation.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ use actix_web::rt;
66
use crate::config::{AgentConfig, KeylimeConfig};
77
use crate::crypto;
88
use crate::secure_mount;
9-
use keylime::keylime_error::*;
10-
use keylime::list_parser::parse_list;
9+
use keylime::{error::*, list_parser::parse_list};
1110
use log::*;
1211
use serde::{Deserialize, Serialize};
1312
use serde_json::Value;

keylime-agent/src/secure_mount.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
use super::*;
55

6-
use keylime::keylime_error::{Error, Result};
6+
use keylime::error::{Error, Result};
77
use std::fs;
88
use std::io::BufRead;
99
use std::os::unix::fs::PermissionsExt;

keylime-push-model-agent/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ fn get_context(args: &Args) -> Result<Option<context_info::ContextInfo>> {
214214
tpm_hash_alg: config.get_tpm_hash_alg(),
215215
tpm_signing_alg: config.get_tpm_signing_alg(),
216216
},
217-
);
217+
)?;
218218
Ok(Some(context_info))
219219
}
220220

keylime-push-model-agent/src/registration.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
use keylime::agent_registration::{
2-
AgentRegistration, AgentRegistrationConfig,
1+
use keylime::{
2+
agent_registration::{AgentRegistration, AgentRegistrationConfig},
3+
cert,
4+
config::PushModelConfigTrait,
5+
context_info,
6+
error::Result,
37
};
4-
use keylime::config::PushModelConfigTrait;
5-
use keylime::keylime_error::Result;
6-
use keylime::{cert, context_info};
78

89
pub async fn check_registration(
910
context_info: Option<context_info::ContextInfo>,
@@ -86,7 +87,8 @@ mod tests {
8687
tpm_hash_alg: "sha256".to_string(),
8788
tpm_signing_alg: "rsassa".to_string(),
8889
};
89-
let mut context_info = ContextInfo::new_from_str(alg_config);
90+
let mut context_info = ContextInfo::new_from_str(alg_config)
91+
.expect("Failed to create context info from string");
9092
let result = register_agent(&config, &mut context_info).await;
9193
assert!(result.is_err());
9294
assert!(context_info.flush_context().is_ok());

keylime-push-model-agent/src/struct_filler.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,8 @@ mod tests {
648648
tpm_hash_alg: config.get_tpm_hash_alg(),
649649
tpm_signing_alg: config.get_tpm_signing_alg(),
650650
},
651-
);
651+
)
652+
.expect("Failed to create context info from string");
652653
let mut filler = FillerFromHardware::new(&mut context_info);
653654
let attestation_request = filler.get_attestation_request_final();
654655
assert_eq!(attestation_request.data.type_, "attestation");
@@ -669,7 +670,8 @@ mod tests {
669670
tpm_hash_alg: config.get_tpm_hash_alg(),
670671
tpm_signing_alg: config.get_tpm_signing_alg(),
671672
},
672-
);
673+
)
674+
.expect("Failed to create context info from string");
673675
let mut filler = FillerFromHardware::new(&mut context_info);
674676
let session_request = filler.get_session_request();
675677
assert_eq!(session_request.data.data_type, "session");
@@ -690,7 +692,8 @@ mod tests {
690692
tpm_hash_alg: config.get_tpm_hash_alg(),
691693
tpm_signing_alg: config.get_tpm_signing_alg(),
692694
},
693-
);
695+
)
696+
.expect("Failed to create context info from string");
694697
let mut filler = FillerFromHardware::new(&mut context_info);
695698
let evidence_handling_request =
696699
filler.get_evidence_handling_request();

keylime/src/agent_data.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use crate::algorithms::{HashAlgorithm, SignAlgorithm};
2-
use crate::keylime_error::Result;
2+
use crate::error::Result;
33
use crate::tpm;
44
use serde::{Deserialize, Serialize};
55
use std::fs::File;

keylime/src/agent_registration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// Copyright 2025 Keylime Authors
3-
use crate::keylime_error::{Error, Result};
43
use crate::{
54
agent_identity::AgentIdentityBuilder,
65
crypto::{self},
76
device_id,
7+
error::{Error, Result},
88
registrar_client::RegistrarClientBuilder,
99
tpm::{self},
1010
};

keylime/src/cert.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
use crate::crypto;
2-
use crate::keylime_error::Result;
1+
use crate::{crypto, error::Result};
32
use log::debug;
43
use openssl::pkey::{PKey, Public};
54
use openssl::x509::X509;

0 commit comments

Comments
 (0)