Apply shellcheck and yamllint fixes to Mockoon CI

Fixed all shellcheck and yamllint issues in the Mockoon testing infrastructure:

Shellcheck fixes in tests/mockoon_registrar_tests.sh:
- Added proper quoting for /proc/$pid paths to prevent word splitting
- Replaced 'cat file | cmd' with 'cmd < file' to avoid useless cat
- Replaced 'ps aux | grep' with 'pgrep' for better process detection
- All variables now properly quoted to prevent globbing

Yamllint fixes in .github/workflows/mockoon.yaml:
- Split long lines (>80 chars) using YAML line continuation
- Improved readability while maintaining functionality
- All debugging commands now properly formatted

The code now passes both shellcheck (only expected SC1091 source
warnings remain) and yamllint with no errors, improving code quality
and maintainability.

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Sergio Arroutbi <[email protected]>

Author: sarroutbi

.github/workflows/mockoon.yaml

@@ -39,19 +39,26 @@ jobs:
         run: |
           echo "======== PRE-MOCKOON SYSTEM STATE ========"
           echo "Available system tools:"
-          command -v lsof && echo "✓ lsof available" || echo "✗ lsof not available"
-          command -v netstat && echo "✓ netstat available" || echo "✗ netstat not available"
-          command -v ss && echo "✓ ss available" || echo "✗ ss available"
-          command -v curl && echo "✓ curl available" || echo "✗ curl not available"
-          command -v docker && echo "✓ docker available" || echo "✗ docker not available"
+          command -v lsof && echo "✓ lsof available" ||
+            echo "✗ lsof not available"
+          command -v netstat && echo "✓ netstat available" ||
+            echo "✗ netstat not available"
+          command -v ss && echo "✓ ss available" ||
+            echo "✗ ss available"
+          command -v curl && echo "✓ curl available" ||
+            echo "✗ curl not available"
+          command -v docker && echo "✓ docker available" ||
+            echo "✗ docker not available"
 
           echo ""
           echo "Current processes using port 3001 (should be none):"
           lsof -i :3001 2>/dev/null || echo "No processes using port 3001"
 
           echo ""
           echo "All listening ports:"
-          netstat -tulpn 2>/dev/null | head -20 || ss -tulpn 2>/dev/null | head -20 || echo "Cannot list ports"
+          netstat -tulpn 2>/dev/null | head -20 ||
+            ss -tulpn 2>/dev/null | head -20 ||
+            echo "Cannot list ports"
 
           echo ""
           echo "Current user and environment:"
@@ -79,23 +86,29 @@ jobs:
         run: |
           echo "======== POST-MOCKOON SYSTEM STATE ========"
           echo "Processes using port 3001 after Mockoon start:"
-          lsof -i :3001 2>/dev/null || echo "No processes using port 3001 (unexpected!)"
+          lsof -i :3001 2>/dev/null ||
+            echo "No processes using port 3001 (unexpected!)"
 
           echo ""
           echo "Mockoon-related processes:"
-          ps aux | grep -i mockoon | grep -v grep || echo "No mockoon processes found"
+          ps aux | grep -i mockoon | grep -v grep ||
+            echo "No mockoon processes found"
 
           echo ""
           echo "Node.js processes:"
-          ps aux | grep -E "(node|npm)" | grep -v grep || echo "No node/npm processes found"
+          ps aux | grep -E "(node|npm)" | grep -v grep ||
+            echo "No node/npm processes found"
 
           echo ""
           echo "Test HTTP connectivity to port 3001:"
-          curl -sI --connect-timeout 5 http://localhost:3001 2>/dev/null || echo "Failed to connect to port 3001"
+          curl -sI --connect-timeout 5 http://localhost:3001 2>/dev/null ||
+            echo "Failed to connect to port 3001"
 
           echo ""
           echo "Network connections:"
-          netstat -tulpn 2>/dev/null | grep ':3001' || ss -tulpn 2>/dev/null | grep ':3001' || echo "No port 3001 connections found"
+          netstat -tulpn 2>/dev/null | grep ':3001' ||
+            ss -tulpn 2>/dev/null | grep ':3001' ||
+            echo "No port 3001 connections found"
           echo "======== END POST-MOCKOON SYSTEM STATE ========"
       - name: Set git safe.directory for the working directory
         run: git config --system --add safe.directory "$PWD"

tests/mockoon_registrar_tests.sh

@@ -70,14 +70,14 @@ log_port_3001_info() {
         for pid in $(lsof -ti :3001 2>/dev/null); do
             echo "  PID: $pid"
             if [ -d "/proc/$pid" ]; then
-                echo "    Command: $(cat /proc/$pid/comm 2>/dev/null || echo 'N/A')"
-                echo "    Cmdline: $(cat /proc/$pid/cmdline 2>/dev/null | tr '\0' ' ' || echo 'N/A')"
-                echo "    User: $(stat -c '%U' /proc/$pid 2>/dev/null || echo 'N/A')"
-                echo "    Parent PID: $(cat /proc/$pid/stat 2>/dev/null | awk '{print $4}' || echo 'N/A')"
-                echo "    Start time: $(stat -c '%Y' /proc/$pid 2>/dev/null | xargs -I {} date -d @{} 2>/dev/null || echo 'N/A')"
-                echo "    Working directory: $(readlink /proc/$pid/cwd 2>/dev/null || echo 'N/A')"
+                echo "    Command: $(cat "/proc/$pid/comm" 2>/dev/null || echo 'N/A')"
+                echo "    Cmdline: $(tr '\0' ' ' < "/proc/$pid/cmdline" 2>/dev/null || echo 'N/A')"
+                echo "    User: $(stat -c '%U' "/proc/$pid" 2>/dev/null || echo 'N/A')"
+                echo "    Parent PID: $(awk '{print $4}' < "/proc/$pid/stat" 2>/dev/null || echo 'N/A')"
+                echo "    Start time: $(stat -c '%Y' "/proc/$pid" 2>/dev/null | xargs -I {} date -d @{} 2>/dev/null || echo 'N/A')"
+                echo "    Working directory: $(readlink "/proc/$pid/cwd" 2>/dev/null || echo 'N/A')"
                 echo "    Environment (filtered):"
-                grep -E "(MOCKOON|NODE|NPM|PATH|USER|HOME)" /proc/$pid/environ 2>/dev/null | tr '\0' '\n' | sed 's/^/      /' || echo "      N/A"
+                grep -E "(MOCKOON|NODE|NPM|PATH|USER|HOME)" "/proc/$pid/environ" 2>/dev/null | tr '\0' '\n' | sed 's/^/      /' || echo "      N/A"
             else
                 echo "    Process details not available (proc not mounted or process gone)"
             fi
@@ -86,11 +86,11 @@ log_port_3001_info() {
     fi
 
     echo "--- Process list (mockoon related) ---"
-    ps aux 2>/dev/null | grep -i mockoon | grep -v grep || echo "No mockoon processes found"
+    pgrep -f -l mockoon 2>/dev/null || echo "No mockoon processes found"
     echo ""
 
     echo "--- Process list (node related on port 3001) ---"
-    ps aux 2>/dev/null | grep -E "(node|npm)" | grep -v grep || echo "No node/npm processes found"
+    { pgrep -f -l node 2>/dev/null; pgrep -f -l npm 2>/dev/null; } | sort -u || echo "No node/npm processes found"
     echo ""
 
     echo "--- Docker containers (if running in container) ---"