Fix clippy warnings

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>

Author: ansasaki

keylime-agent/Cargo.toml

@@ -16,7 +16,7 @@ config.workspace = true
 futures.workspace = true
 glob.workspace = true
 hex.workspace = true
-keylime.workspace = true
+keylime = { workspace = true, features = [] }
 libc.workspace = true
 log.workspace = true
 openssl.workspace = true
@@ -40,7 +40,7 @@ actix-rt.workspace = true
 [features]
 # The features enabled by default
 default = []
-testing = []
+testing = ["keylime/testing"]
 # Whether the agent should be compiled with support to listen for notification
 # messages on ZeroMQ
 #

keylime-push-model-agent/Cargo.toml

@@ -14,7 +14,7 @@ assert_cmd.workspace = true
 async-trait.workspace = true
 chrono.workspace = true
 clap.workspace = true
-keylime.workspace = true
+keylime = { workspace = true, features = [] }
 log.workspace = true
 predicates.workspace = true
 pretty_env_logger.workspace = true
@@ -34,7 +34,7 @@ wiremock = {version = "0.6"}
 [features]
 # The features enabled by default
 default = []
-testing = []
+testing = ["keylime/testing"]
 legacy-python-actions = []
 
 [package.metadata.deb]

keylime-push-model-agent/src/struct_filler.rs

@@ -661,11 +661,7 @@ mod tests {
         if let Ok(mut ctx) = context_info_result {
             // Temporarily override config to point to a non-existent path
             let original_path =
-                std::env::var("KEYLIME_CONFIG_PATH").unwrap_or_default();
-            std::env::set_var(
-                "KEYLIME_CONFIG_PATH",
-                "test-data/non-existent-config.conf",
-            );
+                std::env::var("KEYLIME_AGENT_CONFIG").unwrap_or_default();
 
             // Create a temporary config file with an invalid path for measuredboot_ml_path
             let temp_dir = tempfile::tempdir().unwrap();
@@ -675,16 +671,20 @@ mod tests {
             writeln!(file, "[agent]").unwrap();
             writeln!(
                 file,
-                "measuredboot_ml_path = /path/to/non/existent/log"
+                "measuredboot_ml_path = \"/path/to/non/existent/log\""
             )
             .unwrap();
-            std::env::set_var("KEYLIME_CONFIG_PATH", config_path);
+            std::env::set_var("KEYLIME_AGENT_CONFIG", config_path);
 
             let filler = FillerFromHardware::new(&mut ctx);
             assert!(filler.uefi_log_handler.is_none());
 
             // Restore original config path
-            std::env::set_var("KEYLIME_CONFIG_PATH", original_path);
+            if original_path.is_empty() {
+                std::env::remove_var("KEYLIME_AGENT_CONFIG");
+            } else {
+                std::env::set_var("KEYLIME_AGENT_CONFIG", original_path);
+            }
             assert!(ctx.flush_context().is_ok());
         }
     }

keylimectl/src/commands/agent.rs

@@ -2130,12 +2130,13 @@ async fn validate_tpm_quote(
     }
 
     // Handle the 'r' prefix - remove the single 'r' character as documented
-    let quote_data_clean = if let Some(stripped) = quote_data.strip_prefix('r') {
-        debug!("Removing 'r' prefix from quote data");
-        stripped
-    } else {
-        quote_data
-    };
+    let quote_data_clean =
+        if let Some(stripped) = quote_data.strip_prefix('r') {
+            debug!("Removing 'r' prefix from quote data");
+            stripped
+        } else {
+            quote_data
+        };
 
     debug!("Cleaned quote data length: {}", quote_data_clean.len());
 

keylimectl/src/config/error.rs

@@ -33,6 +33,7 @@ use thiserror::Error;
 /// This enum covers all error conditions that can occur during configuration
 /// operations, from file loading to validation and environment variable processing.
 #[derive(Error, Debug)]
+#[allow(dead_code)]
 pub enum ConfigError {
     /// Configuration file loading errors
     #[error("Configuration file error: {0}")]
@@ -56,13 +57,15 @@ pub enum ConfigError {
 /// These errors represent issues when loading configuration files,
 /// including file system errors and format issues.
 #[derive(Error, Debug)]
+#[allow(dead_code)]
 pub enum LoadError {}
 
 /// Configuration validation errors
 ///
 /// These errors represent validation failures for specific configuration
 /// values, providing detailed context about what is wrong and how to fix it.
 #[derive(Error, Debug)]
+#[allow(dead_code)]
 pub enum ValidationError {}
 
 impl ConfigError {}