feat(windows): review suggestions

Co-authored-by: Marc Durdin <[email protected]>

Author: rc-swag

core/src/kmx/kmx_processor.cpp

@@ -105,23 +105,22 @@ kmx_processor::update_option(
 
 km_kbp_status
 kmx_processor::external_event(
-      km_kbp_state* state,
-      uint32_t event,
-      void* _kmn_unused(data)
-      ) {
+  km_kbp_state* state,
+  uint32_t event,
+  void* _kmn_unused(data)
+) {
 
-  switch (event){
-    case KM_KBP_EVENT_KEYBOARD_ACTIVATED:{
+  switch (event) {
+    case KM_KBP_EVENT_KEYBOARD_ACTIVATED:
       // reset any current actions in the queue as a new keyboard
       // has been activated
       _kmx.GetActions()->ResetQueue();
       state->actions().clear();
-    KMX_DWORD dummy_modifiers = 0;
-    if (_kmx.GetKeyboard()->Keyboard->dwFlags & KF_CAPSALWAYSOFF) {
-      _kmx.SetCapsLock(dummy_modifiers, FALSE, TRUE);
+      if (_kmx.GetKeyboard()->Keyboard->dwFlags & KF_CAPSALWAYSOFF) {
+        KMX_DWORD dummy_modifiers = 0;
+        _kmx.SetCapsLock(dummy_modifiers, FALSE, TRUE);
       }
-    }
-    break;
+      break;
     default:
       return KM_KBP_STATUS_INVALID_ARGUMENT;
   }

core/tests/unit/kmx/kmx_external_event.cpp

@@ -19,10 +19,10 @@
 #include <iostream>
 #include <sstream>
 
-/** This test will test the infrastructure around the external event processing
- *  The functions tested are:
- *  km_kbp_event with the event KM_KBP_EVENT_KEYBOARD_ACTIVATED
- *
+/** 
+ * This test will test the infrastructure around the external event processing
+ * The functions tested are:
+ * - km_kbp_event with the event KM_KBP_EVENT_KEYBOARD_ACTIVATED
  */
 
 using namespace km::kbp::kmx;
@@ -33,8 +33,8 @@ km_kbp_option_item test_env_opts[] =
 };
 
 int error_args() {
-    std::cerr << "kmx: Not enough arguments." << std::endl;
-    return 1;
+  std::cerr << "kmx: Not enough arguments." << std::endl;
+  return 1;
 }
 
 void test_external_event(const km::kbp::path &source_file){

windows/src/engine/keyman32/kmprocessactions.cpp

@@ -218,7 +218,7 @@ ProcessActionsExternalEvent() {
   if (!_td) {
     return FALSE;
   }
-  // Currently the only Action handled is KM_KBP_IT_CAPSLOCK.
+  // Currently only a subset of actions are handled.
   // Other actions will be added when needed.
   BOOL continueProcessingActions = TRUE;
   for (auto act = km_kbp_state_action_items(_td->lpActiveKeyboard->lpCoreKeyboardState, nullptr); act->type != KM_KBP_IT_END;

windows/src/engine/keyman32/kmprocessactions.h

@@ -30,9 +30,9 @@ BOOL ProcessActionsNonUpdatableParse(BOOL* emitKeyStroke);
  * This function processes the actions queued in the core processor in
  * the external event case. That is actions not caused by a keystroke but from selecting a
  * different keyboard for example.
- * Currently only CAPS Lock and invalidate key stroke are processed.
+ * Currently only KM_KBP_IT_CAPSLOCK and KM_KBP_IT_INVALIDATE_CONTEXT are processed.
  *
- * @return BOOL  True if actions were successfully processed
+ * @return BOOL  TRUE if actions were successfully processed
  */
 BOOL ProcessActionsExternalEvent();