Skip to content

Commit 4ecaad6

Browse files
committed
chore(linux): Address code review comments
1 parent 1b5a866 commit 4ecaad6

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

linux/ibus-keyman/tests/scripts/run-single-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ fi
2121

2222
function help() {
2323
echo "Usage:"
24-
echo " $0 [--env <envfile>] [-k] [--tap] [--surrounding-text] [--no-surrounding-text] [--wayland|--x11] [--] TEST"
24+
echo " $0 [--env <envfile>] [-k] [--tap] [--surrounding-text] [--no-surrounding-text] [--wayland|--x11] [--check <pidfile> --cleanup <file>] [--] TEST"
2525
echo
2626
echo "Arguments:"
2727
echo " --help, -h, -? Display this help"

linux/ibus-keyman/tests/scripts/test-helper.inc.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,8 @@ function _setup_display_server() {
203203
}
204204

205205
function _setup_schema_and_gsettings() {
206-
local ENV_FILE CLEANUP_FILE
206+
local ENV_FILE
207207
ENV_FILE=$1
208-
CLEANUP_FILE=$2
209208

210209
# Install schema to temporary directory. This removes the build dependency on the keyman package.
211210
SCHEMA_DIR=$TEMP_DATA_DIR/glib-2.0/schemas
@@ -275,7 +274,7 @@ function setup() {
275274

276275
_setup_test_dbus_server "${ENV_FILE}" "${CLEANUP_FILE}"
277276
_setup_display_server "${ENV_FILE}" "${CLEANUP_FILE}" "${PID_FILE}" "${DISPLAY_SERVER}"
278-
_setup_schema_and_gsettings "${ENV_FILE}" "${CLEANUP_FILE}"
277+
_setup_schema_and_gsettings "${ENV_FILE}"
279278
_setup_ibus "${ENV_FILE}" "${CLEANUP_FILE}" "${PID_FILE}"
280279
}
281280

@@ -288,7 +287,7 @@ function setup_display_server_only() {
288287

289288
_setup_init "${ENV_FILE}" "${CLEANUP_FILE}" "${PID_FILE}"
290289
_setup_display_server "${ENV_FILE}" "${CLEANUP_FILE}" "${PID_FILE}" "${DISPLAY_SERVER}"
291-
_setup_schema_and_gsettings "${ENV_FILE}" "${CLEANUP_FILE}"
290+
_setup_schema_and_gsettings "${ENV_FILE}"
292291
}
293292

294293
function cleanup() {

0 commit comments

Comments
 (0)