Skip to content

Commit 960a559

Browse files
committed
feat(core): icu build fix 🙀
- correctly disable some ICU features For: #9121
1 parent 7a31252 commit 960a559

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

core/subprojects/packagefiles/icu/meson.build

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ endif
2626

2727
# per icudefs.mk.in:
2828
# "U_ATTRIBUTE_DEPRECATED is defined to hide warnings about deprecated API warnings."
29-
add_project_arguments('-DU_ATTRIBUTE_DEPRECATED=', '-DUCONFIG_USE_LOCAL=1', language: 'c')
30-
31-
add_project_arguments('-DU_NOEXCEPT=', language: 'c')
29+
add_project_arguments('-DU_NOEXCEPT=', '-DU_ATTRIBUTE_DEPRECATED=', '-DUCONFIG_USE_LOCAL=1', language: 'c')
30+
add_project_arguments('-DU_NOEXCEPT=', '-DU_ATTRIBUTE_DEPRECATED=', '-DUCONFIG_USE_LOCAL=1', language: 'cpp')
3231

3332
uconfig = configuration_data()
3433

@@ -42,7 +41,7 @@ uconfig.set('UCONFIG_NO_IDNA', 1)
4241
uconfig.set('UCONFIG_NO_COLLATION', 1)
4342
uconfig.set('UCONFIG_NO_FORMATTING', 1)
4443
uconfig.set('UCONFIG_NO_TRANSLITERATION', 1)
45-
uconfig.set('UCONFIG_NO_REGULAR_EXPRESSIONS', 1) # TODO-LDML: Will probably want this for transforms #7375
44+
uconfig.set('UCONFIG_NO_REGULAR_EXPRESSIONS', 0) # want these for transforms #7375
4645
uconfig.set('UCONFIG_NO_SERVICE', 1)
4746

4847

0 commit comments

Comments
 (0)