chore(developer): remove Package Installer UI from TIKE

Author: mcdurdin

developer/src/common/delphi/compiler/CompilePackage.pas

@@ -1134,7 +1134,6 @@ inherited frmPackageEditor: TfrmPackageEditor
           Anchors = [akLeft, akTop, akRight]
           TabOrder = 2
           OnClick = cbLicenseClick
-          ExplicitWidth = 482
         end
       end
     end
@@ -1351,7 +1350,7 @@ inherited frmPackageEditor: TfrmPackageEditor
           BevelOuter = bvNone
           Color = 15921906
           ParentBackground = False
-          TabOrder = 4
+          TabOrder = 3
           object lblDebugHostCaption: TLabel
             Left = 12
             Top = 70
@@ -1438,7 +1437,7 @@ inherited frmPackageEditor: TfrmPackageEditor
           Left = 15
           Top = 274
           Width = 295
-          Height = 124
+          Height = 276
           BevelOuter = bvNone
           Color = 15921906
           ParentBackground = False
@@ -1484,74 +1483,6 @@ inherited frmPackageEditor: TfrmPackageEditor
             OnClick = cmdUninstallClick
           end
         end
-        object panBuildWindowsInstaller: TPanel
-          Left = 15
-          Top = 418
-          Width = 295
-          Height = 132
-          BevelOuter = bvNone
-          Color = 15921906
-          ParentBackground = False
-          TabOrder = 3
-          object Label9: TLabel
-            Left = 9
-            Top = 6
-            Width = 124
-            Height = 17
-            Caption = 'Windows Installer'
-            Font.Charset = DEFAULT_CHARSET
-            Font.Color = clWindowText
-            Font.Height = -14
-            Font.Name = 'Tahoma'
-            Font.Style = [fsBold]
-            ParentFont = False
-          end
-          object lblBootstrapMSI: TLabel
-            Left = 9
-            Top = 69
-            Width = 64
-            Height = 13
-            Caption = 'Keyman MSI:'
-            FocusControl = editBootstrapMSI
-          end
-          object lblInstallerOutputFilename: TLabel
-            Left = 9
-            Top = 37
-            Width = 82
-            Height = 13
-            Caption = 'Target filename:'
-            FocusControl = editInstallerOutputFilename
-          end
-          object editBootstrapMSI: TEdit
-            Left = 125
-            Top = 66
-            Width = 156
-            Height = 21
-            TabStop = False
-            ParentColor = True
-            ReadOnly = True
-            TabOrder = 1
-          end
-          object editInstallerOutputFilename: TEdit
-            Left = 125
-            Top = 34
-            Width = 156
-            Height = 21
-            TabStop = False
-            ParentColor = True
-            ReadOnly = True
-            TabOrder = 0
-          end
-          object cmdInstallWith: TButton
-            Left = 125
-            Top = 96
-            Width = 156
-            Height = 25
-            Caption = 'Find Keyman MSI...'
-            TabOrder = 2
-            OnClick = cmdInstallWithClick
-          end
-        end
         object panOpenInExplorer: TPanel
           Left = 15
           Top = 187
@@ -1641,30 +1572,21 @@ inherited frmPackageEditor: TfrmPackageEditor
             ReadOnly = True
             TabOrder = 0
           end
-          object cmdCompileInstaller: TButton
-            Left = 148
-            Top = 32
-            Width = 133
-            Height = 25
-            Caption = 'Compile I&nstaller'
-            TabOrder = 1
-            OnClick = cmdCompileInstallerClick
-          end
           object cmdAddToProject: TButton
-            Left = 287
+            Left = 148
             Top = 32
             Width = 133
             Height = 25
             Action = modActionsMain.actProjectAddCurrentEditorFile
-            TabOrder = 2
+            TabOrder = 1
           end
           object cmdBuildPackage: TButton
             Left = 9
             Top = 32
             Width = 133
             Height = 25
             Caption = 'Compile &Package'
-            TabOrder = 3
+            TabOrder = 2
             OnClick = cmdBuildPackageClick
           end
         end
@@ -1685,12 +1607,4 @@ inherited frmPackageEditor: TfrmPackageEditor
     Left = 32
     Top = 532
   end
-  object dlgOpenProductInstaller: TOpenDialog
-    DefaultExt = 'msi'
-    Filter = 'Product Installer Files (*.msi)|*.msi|All Files (*.*)|*.*'
-    Options = [ofHideReadOnly, ofPathMustExist, ofFileMustExist, ofEnableSizing]
-    Title = 'Select Product Installer'
-    Left = 32
-    Top = 456
-  end
 end

developer/src/common/delphi/compiler/CompilePackageInstaller.pas

@@ -69,7 +69,6 @@ interface
   TfrmPackageEditor = class(TfrmTikeEditor)   // I4689
     dlgFiles: TOpenDialog;
     dlgNewCustomisation: TSaveDialog;
-    dlgOpenProductInstaller: TOpenDialog;
     pages: TLeftTabbedPageControl;
     pageFiles: TTabSheet;
     pageDetails: TTabSheet;
@@ -169,13 +168,6 @@   TfrmPackageEditor = class(TfrmTikeEditor)   // I4689
     lblCompileTargetHeader: TLabel;
     cmdInstall: TButton;
     cmdUninstall: TButton;
-    panBuildWindowsInstaller: TPanel;
-    Label9: TLabel;
-    lblBootstrapMSI: TLabel;
-    lblInstallerOutputFilename: TLabel;
-    editBootstrapMSI: TEdit;
-    editInstallerOutputFilename: TEdit;
-    cmdInstallWith: TButton;
     pageLexicalModels: TTabSheet;
     panLexicalModels: TPanel;
     lblLexlicalModels: TLabel;
@@ -200,7 +192,6 @@   TfrmPackageEditor = class(TfrmTikeEditor)   // I4689
     panFileActions: TPanel;
     lblFileActions: TLabel;
     editOutPath: TEdit;
-    cmdCompileInstaller: TButton;
     cmdAddToProject: TButton;
     cmdBuildPackage: TButton;
     Label5: TLabel;
@@ -256,8 +247,6 @@   TfrmPackageEditor = class(TfrmTikeEditor)   // I4689
     procedure cmdUninstallClick(Sender: TObject);
     procedure cmdOpenContainingFolderClick(Sender: TObject);
     procedure cmdOpenFileClick(Sender: TObject);
-    procedure cmdCompileInstallerClick(Sender: TObject);
-    procedure cmdInstallWithClick(Sender: TObject);
     procedure FormKeyDown(Sender: TObject; var Key: Word; Shift: TShiftState);
     procedure pagesChanging(Sender: TObject;
       var AllowChange: Boolean);
@@ -395,7 +384,6 @@ implementation
 
   CharMapDropTool,
   CharMapInsertMode,
-  CompilePackageInstaller,
   Keyman.Developer.System.Project.kpsProjectFile,
   Keyman.Developer.System.Project.kpsProjectFileAction,
   Keyman.Developer.System.ServerAPI,
@@ -492,17 +480,6 @@ procedure TfrmPackageEditor.SourceChanged(Sender: TObject);
     Modified := True;
 end;
 
-procedure TfrmPackageEditor.cmdCompileInstallerClick(Sender: TObject);
-begin
-  if Untitled or Modified then   // I2178
-    ShowMessage('You must save the package before you can build it.')
-  else
-  begin
-    frmMessages.Clear;
-    DoAction(pfaCompileInstaller);
-  end;
-end;
-
 procedure TfrmPackageEditor.cmdCopyDebuggerLinkClick(Sender: TObject);
 begin
   try
@@ -1267,17 +1244,6 @@ procedure TfrmPackageEditor.cmdInstallClick(Sender: TObject);
   DoAction(pfaInstall);
 end;
 
-procedure TfrmPackageEditor.cmdInstallWithClick(Sender: TObject);
-begin
-  dlgOpenProductInstaller.FileName := pack.KPSOptions.MSIFileName;
-  if dlgOpenProductInstaller.Execute then
-  begin
-    pack.KPSOptions.MSIFileName := dlgOpenProductInstaller.FileName;
-    Modified := True;
-    UpdateData;
-  end;
-end;
-
 {-------------------------------------------------------------------------------
  - Display refresh routines                                                    -
  -------------------------------------------------------------------------------}
@@ -1350,10 +1316,6 @@ procedure TfrmPackageEditor.UpdateData;
     editStartMenuPath.Text := pack.StartMenu.Path;
 
     editOutPath.Text := (ProjectFile as TkpsProjectFile).TargetFilename;   // I4688
-    editBootstrapMSI.Text := pack.KPSOptions.MSIFileName;
-    if pack.KPSOptions.MSIFileName = ''
-      then editInstallerOutputFilename.Text := ''
-      else editInstallerOutputFilename.Text := (ProjectFile as TkpsProjectFile).TargetInstallerFileName;   // I4688
 
     if lbFiles.Items.Count > 0 then lbFiles.ItemIndex := 0;
     lbFilesClick(lbFiles);
@@ -1983,7 +1945,6 @@ procedure TfrmPackageEditor.RefreshTargetPanels;
   end;
 
   panBuildDesktop.Visible := FHasDesktopTarget;
-  panBuildWindowsInstaller.Visible := FHasDesktopTarget;
   panBuildMobile.Visible := FHasMobileTarget;
 end;
 

developer/src/tike/child/UfrmPackageEditor.dfm

@@ -15,24 +15,13 @@ interface
 
 type
   TkpsProjectFileAction = class(TkpsProjectFile)
-  private
-    procedure SelfMessage(Sender: TObject; msg: string; State: TProjectLogState);   // I4706
-
   public
-    function CompilePackageInstaller(APack: TKPSFile; FSilent: Boolean): Boolean;
     function CompilePackage: Boolean;
     function Clean: Boolean;
   end;
 
 implementation
 
-uses
-  compile,
-  CompilePackageInstaller,
-  Keyman.Developer.System.ValidateKpsFile,
-  PackageInfo,
-  utilexecute;
-
 function TkpsProjectFileAction.CompilePackage: Boolean;
 var
   w: TKmcWrapper;
@@ -46,59 +35,13 @@ function TkpsProjectFileAction.CompilePackage: Boolean;
   end;
 end;
 
-function TkpsProjectFileAction.CompilePackageInstaller(APack: TKPSFile; FSilent: Boolean): Boolean;
-var
-  pack: TKPSFile;
-begin
-  HasCompileWarning := False;   // I4706
-
-  if APack = nil then
-  begin
-    pack := TKPSFile.Create;
-    pack.FileName := FileName;
-    pack.LoadXML;
-  end
-  else
-    pack := APack;
-
-  try
-    try
-      Result := DoCompilePackageInstaller(pack, SelfMessage, FSilent, '', TargetInstallerFilename, '', False, True, '', '', '', False, False);
-      if HasCompileWarning and (WarnAsError or OwnerProject.Options.CompilerWarningsAsErrors) then   // I4706
-        Result := False;
-
-      if Result
-        then Log(plsSuccess, '''' + FileName + ''' compiled successfully.', 0, 0)
-        else Log(plsFailure, '''' + FileName + ''' was not compiled successfully.', 0, 0);
-    except
-      on E:Exception do
-      begin
-        Log(plsError, E.Message, CERR_ERROR, 0);
-        Log(plsFailure, '''' + FileName + ''' was not compiled successfully.', 0, 0);
-        Result := False;
-      end;
-    end;
-
-  finally
-    if APack = nil then
-      pack.Free;
-  end;
-end;
-
 function TkpsProjectFileAction.Clean: Boolean;
 begin
   CleanFile(OutputFileName);
   CleanFile(TargetInstallerFilename);   // I4737
   Result := True;
 end;
 
-procedure TkpsProjectFileAction.SelfMessage(Sender: TObject; msg: string; State: TProjectLogState);   // I4706
-begin
-  if State = plsWarning then
-    HasCompileWarning := True;
-  Log(State, msg, 0, 0);
-end;
-
 initialization
   RegisterProjectFileType('.kps', TkpsProjectFileAction);
 end.

developer/src/tike/child/UfrmPackageEditor.pas

@@ -34,7 +34,7 @@ interface
 
 type
   TProjectFileAction = (pfaCompile, pfaInstall, pfaUninstall, pfaDebug,
-    pfaTestKeymanWeb, pfaCompileInstaller, pfaFontHelper, pfaFontDialog, pfaClean);   // I4057
+    pfaTestKeymanWeb, pfaFontHelper, pfaFontDialog, pfaClean);   // I4057
 
   TProjectUI = class(TProject)
   private

developer/src/tike/project/Keyman.Developer.System.Project.kpsProjectFileAction.pas

@@ -549,21 +549,6 @@ procedure TfrmProject.WebCommandProject(Command: WideString; Params: TStringList
         (FGlobalProject.Files[i].UI as TProjectFileUI).DoAction(pfaCompile, False);
     end;
   end
-  else if Command = 'package_compileallinstallers' then   // I4734
-  begin
-    ClearMessages;
-    for i := 0 to FGlobalProject.Files.Count - 1 do
-    begin
-      if FGlobalProject.Files[i] is TkpsProjectFile then
-        (FGlobalProject.Files[i].UI as TProjectFileUI).DoAction(pfaCompileInstaller, False);
-    end;
-  end
-  else if Command = 'package_compileinstaller' then
-  begin
-    ClearMessages;
-    pf := SelectedProjectFile;
-    if Assigned(pf) then (pf.UI as TProjectFileUI).DoAction(pfaCompileInstaller, False);
-  end
   else if Command = 'package_cleanall' then   // I4692
   begin
     ClearMessages;