Skip to content

Commit 3b4104a

Browse files
committed
#991 feat: consolidate volume stream actions
1 parent 4055f09 commit 3b4104a

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

base/src/main/java/io/github/sds100/keymapper/base/actions/ConfigActionsViewModel.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ class ConfigActionsViewModel @Inject constructor(
8282
combine(config.keyMap, actionOptionsUid, transform = ::buildOptionsState)
8383
.stateIn(viewModelScope, SharingStarted.Lazily, null)
8484

85+
private var editedActionUid: String? = null
86+
8587
private val actionErrorSnapshot: StateFlow<ActionErrorSnapshot?> =
8688
displayAction.actionErrorSnapshot.stateIn(viewModelScope, SharingStarted.Lazily, null)
8789

@@ -99,7 +101,7 @@ class ConfigActionsViewModel @Inject constructor(
99101

100102
viewModelScope.launch {
101103
createActionDelegate.actionResult.filterNotNull().collect { action ->
102-
val actionUid = actionOptionsUid.value ?: return@collect
104+
val actionUid = editedActionUid ?: return@collect
103105
config.setActionData(actionUid, action)
104106
actionOptionsUid.update { null }
105107
}
@@ -186,6 +188,7 @@ class ConfigActionsViewModel @Inject constructor(
186188
viewModelScope.launch {
187189
// Clear the bottom sheet so navigating back with predicted-back works
188190
actionOptionsUid.update { null }
191+
editedActionUid = actionUid
189192

190193
val keyMap = config.keyMap.first().dataOrNull() ?: return@launch
191194

base/src/main/java/io/github/sds100/keymapper/base/actions/CreateActionDelegate.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import io.github.sds100.keymapper.base.actions.tapscreen.PickCoordinateResult
1111
import io.github.sds100.keymapper.base.system.intents.ConfigIntentResult
1212
import io.github.sds100.keymapper.base.utils.DndModeStrings
1313
import io.github.sds100.keymapper.base.utils.RingerModeStrings
14-
import io.github.sds100.keymapper.base.utils.VolumeStreamStrings
1514
import io.github.sds100.keymapper.base.utils.navigation.NavDestination
1615
import io.github.sds100.keymapper.base.utils.navigation.NavigationProvider
1716
import io.github.sds100.keymapper.base.utils.navigation.navigate

base/src/main/java/io/github/sds100/keymapper/base/actions/VolumeActionBottomSheet.kt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package io.github.sds100.keymapper.base.actions
22

33
import androidx.compose.foundation.layout.Arrangement
4-
import androidx.compose.foundation.layout.Box
54
import androidx.compose.foundation.layout.Column
65
import androidx.compose.foundation.layout.Row
76
import androidx.compose.foundation.layout.Spacer
@@ -45,6 +44,12 @@ import io.github.sds100.keymapper.base.utils.ui.compose.RadioButtonText
4544
import io.github.sds100.keymapper.system.volume.VolumeStream
4645
import kotlinx.coroutines.launch
4746

47+
data class VolumeActionBottomSheetState(
48+
val actionId: ActionId,
49+
val volumeStream: VolumeStream?,
50+
val showVolumeUi: Boolean,
51+
)
52+
4853
@OptIn(ExperimentalMaterial3Api::class)
4954
@Composable
5055
fun VolumeActionBottomSheet(delegate: CreateActionDelegate) {
@@ -196,12 +201,6 @@ private fun VolumeActionBottomSheet(
196201
}
197202
}
198203

199-
data class VolumeActionBottomSheetState(
200-
val actionId: ActionId,
201-
val volumeStream: VolumeStream?,
202-
val showVolumeUi: Boolean,
203-
)
204-
205204
@OptIn(ExperimentalMaterial3Api::class)
206205
@Preview
207206
@Composable

0 commit comments

Comments
 (0)