refactor: use MaxKeyCode for scanCode offset

refactor: don't offset negative scanCode

Author: kamilkrzyskow

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/trigger/BaseConfigTriggerViewModel.kt

@@ -456,7 +456,7 @@ abstract class BaseConfigTriggerViewModel(
         // need to be dismissed before it is added.
         config.addKeyCodeTriggerKey(key.keyCode, key.device, key.detectionSource)
 
-        if (key.keyCode >= InputEventUtils.KEYCODE_TO_SCANCODE_OFFSET) {
+        if (key.keyCode >= InputEventUtils.KEYCODE_TO_SCANCODE_OFFSET || key.keyCode < 0) {
             if (onboarding.shownKeyCodeToScanCodeTriggerExplanation) {
                 return
             }

app/src/main/java/io/github/sds100/keymapper/system/accessibility/BaseAccessibilityServiceController.kt

@@ -304,10 +304,17 @@ abstract class BaseAccessibilityServiceController(
         // Guard to ignore processing when not applicable
         if (event.keyCode != KeyEvent.KEYCODE_UNKNOWN) return event
 
+        // Don't offset negative values
+        val scanCodeOffset: Int = if (event.scanCode >= 0) {
+            InputEventUtils.KEYCODE_TO_SCANCODE_OFFSET
+        } else {
+            0
+        }
+
         val eventProxy = event.copy(
             // Fallback to scanCode when keyCode is unknown as it's typically more unique
             // Add offset to go past possible keyCode values
-            keyCode = event.scanCode + InputEventUtils.KEYCODE_TO_SCANCODE_OFFSET,
+            keyCode = event.scanCode + scanCodeOffset,
         )
 
         return eventProxy

app/src/main/java/io/github/sds100/keymapper/system/inputevents/InputEventUtils.kt

@@ -689,14 +689,15 @@ object InputEventUtils {
     /**
      * Used for keyCode to scanCode fallback to go past possible keyCode values
      */
-    const val KEYCODE_TO_SCANCODE_OFFSET: Int = 1000
+    val KEYCODE_TO_SCANCODE_OFFSET: Int
+        get() = KeyEvent.getMaxKeyCode() + 1
 
     /**
      * Create a text representation of a key event. E.g if the control key was pressed,
      * "Ctrl" will be returned
      */
     fun keyCodeToString(keyCode: Int): String = NON_CHARACTER_KEY_LABELS[keyCode].let {
-        if (keyCode >= KEYCODE_TO_SCANCODE_OFFSET) {
+        if (keyCode >= KEYCODE_TO_SCANCODE_OFFSET || keyCode < 0) {
             "scancode $keyCode"
         } else {
             it ?: "unknown keycode $keyCode"