Skip to content

Commit b2d9f2c

Browse files
committed
#1946 feat: change record trigger button text when recording with expert mode
1 parent b654702 commit b2d9f2c

File tree

3 files changed

+21
-2
lines changed

3 files changed

+21
-2
lines changed

base/src/main/java/io/github/sds100/keymapper/base/trigger/RecordTriggerButtonRow.kt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ fun RecordTriggerButtonRow(
6767
RecordTriggerButton(
6868
modifier = Modifier.weight(1f),
6969
recordTriggerState,
70+
isExpertModeRecordingEnabled = expertModeRecordSwitchState.isChecked,
7071
onClick = onRecordTriggerClick,
7172
)
7273

@@ -105,7 +106,12 @@ private fun ExpertModeSwitch(
105106
}
106107

107108
@Composable
108-
fun RecordTriggerButton(modifier: Modifier, state: RecordTriggerState, onClick: () -> Unit) {
109+
fun RecordTriggerButton(
110+
modifier: Modifier,
111+
state: RecordTriggerState,
112+
isExpertModeRecordingEnabled: Boolean,
113+
onClick: () -> Unit,
114+
) {
109115
val colors = ButtonDefaults.filledTonalButtonColors().copy(
110116
containerColor = LocalCustomColorsPalette.current.red,
111117
contentColor = LocalCustomColorsPalette.current.onRed,
@@ -115,8 +121,11 @@ fun RecordTriggerButton(modifier: Modifier, state: RecordTriggerState, onClick:
115121
is RecordTriggerState.CountingDown ->
116122
stringResource(R.string.button_recording_trigger_countdown, state.timeLeft)
117123

118-
else ->
124+
else -> if (isExpertModeRecordingEnabled) {
125+
stringResource(R.string.button_record_trigger_expert_mode)
126+
} else {
119127
stringResource(R.string.button_record_trigger)
128+
}
120129
}
121130

122131
// Create pulsing animation for the recording dot

base/src/main/java/io/github/sds100/keymapper/base/trigger/TriggerSetupBottomSheet.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ private fun GamepadTriggerSetupBottomSheet(
183183
RecordTriggerButton(
184184
modifier = Modifier.weight(1f),
185185
state = state.recordTriggerState,
186+
isExpertModeRecordingEnabled =
187+
state is TriggerSetupState.Gamepad.SimpleButtons &&
188+
state.isUseExpertModeChecked,
186189
onClick = onRecordTriggerClick,
187190
)
188191
} else {
@@ -298,6 +301,7 @@ private fun MouseTriggerSetupBottomSheet(
298301
RecordTriggerButton(
299302
modifier = Modifier.weight(1f),
300303
state = state.recordTriggerState,
304+
isExpertModeRecordingEnabled = true,
301305
onClick = onRecordTriggerClick,
302306
)
303307
} else {
@@ -353,6 +357,7 @@ private fun PowerTriggerSetupBottomSheet(
353357
RecordTriggerButton(
354358
modifier = Modifier.weight(1f),
355359
state = state.recordTriggerState,
360+
isExpertModeRecordingEnabled = true,
356361
onClick = onRecordTriggerClick,
357362
)
358363
} else {
@@ -440,6 +445,7 @@ private fun VolumeTriggerSetupBottomSheet(
440445
RecordTriggerButton(
441446
modifier = Modifier.weight(1f),
442447
state = state.recordTriggerState,
448+
isExpertModeRecordingEnabled = state.isUseExpertModeChecked,
443449
onClick = onRecordTriggerClick,
444450
)
445451
} else {
@@ -500,6 +506,7 @@ private fun NotDetectedSetupBottomSheet(
500506
RecordTriggerButton(
501507
modifier = Modifier.weight(1f),
502508
state = state.recordTriggerState,
509+
isExpertModeRecordingEnabled = true,
503510
onClick = onRecordTriggerClick,
504511
)
505512
} else {
@@ -586,6 +593,7 @@ private fun OtherTriggerSetupBottomSheet(
586593
RecordTriggerButton(
587594
modifier = Modifier.weight(1f),
588595
state = state.recordTriggerState,
596+
isExpertModeRecordingEnabled = state.isUseExpertModeChecked,
589597
onClick = onRecordTriggerClick,
590598
)
591599
} else {
@@ -670,6 +678,7 @@ private fun KeyboardTriggerSetupBottomSheet(
670678
RecordTriggerButton(
671679
modifier = Modifier.weight(1f),
672680
state = state.recordTriggerState,
681+
isExpertModeRecordingEnabled = state.isUseExpertModeChecked,
673682
onClick = onRecordTriggerClick,
674683
)
675684
} else {

base/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@
407407
<!-- Button titles -->
408408
<string name="button_add_action">Add action</string>
409409
<string name="button_record_trigger">Tap to record trigger</string>
410+
<string name="button_record_trigger_expert_mode">Record with Expert Mode</string>
410411
<string name="button_advanced_triggers_badge">NEW!</string>
411412
<string name="button_done">Done</string>
412413
<string name="button_fix">Fix</string>

0 commit comments

Comments
 (0)