#1871 feat: complete modify system setting action

Author: sds100

CHANGELOG.md

@@ -1,3 +1,10 @@
+## [4.0.0 Beta 3](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.03)
+
+#### TO BE RELEASED
+
+## Added
+- #1871 action to modify any system settings
+
 ## [4.0.0 Beta 2](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.02)
 
 #### 08 November 2025

base/src/main/assets/whats-new.txt

@@ -6,6 +6,7 @@ You can now remap ALL buttons when the screen is off (including the power button
 • Send SMS messages
 • Force stop current app or clear from recents
 • Mute/unmute microphone
+• Modify any system setting
 
 🆕 New Features
 • Redesigned Settings screen

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionUiHelper.kt

@@ -653,17 +653,9 @@ class ActionUiHelper(
         ActionData.Microphone.Unmute -> getString(R.string.action_unmute_microphone)
 
         is ActionData.ModifySetting -> {
-            val typeString = when (action.settingType) {
-                io.github.sds100.keymapper.system.settings.SettingType.SYSTEM ->
-                    getString(R.string.modify_setting_type_system)
-                io.github.sds100.keymapper.system.settings.SettingType.SECURE ->
-                    getString(R.string.modify_setting_type_secure)
-                io.github.sds100.keymapper.system.settings.SettingType.GLOBAL ->
-                    getString(R.string.modify_setting_type_global)
-            }
             getString(
                 R.string.modify_setting_description,
-                arrayOf(action.settingKey, action.value, typeString),
+                arrayOf(action.settingKey, action.value),
             )
         }
     }

base/src/main/java/io/github/sds100/keymapper/base/actions/CreateActionDelegate.kt

@@ -4,6 +4,7 @@ import android.text.InputType
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.setValue
+import androidx.compose.runtime.snapshotFlow
 import io.github.sds100.keymapper.base.R
 import io.github.sds100.keymapper.base.actions.pinchscreen.PinchPickCoordinateResult
 import io.github.sds100.keymapper.base.actions.swipescreen.SwipePickCoordinateResult
@@ -29,13 +30,17 @@ import io.github.sds100.keymapper.system.volume.DndMode
 import io.github.sds100.keymapper.system.volume.RingerMode
 import io.github.sds100.keymapper.system.volume.VolumeStream
 import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.collectLatest
+import kotlinx.coroutines.flow.filterNotNull
 import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
 import kotlinx.serialization.json.Json
 
+@OptIn(ExperimentalCoroutinesApi::class)
 class CreateActionDelegate(
     private val coroutineScope: CoroutineScope,
     private val useCase: CreateActionUseCase,
@@ -67,6 +72,22 @@ class CreateActionDelegate(
                 }
             }
         }
+
+        coroutineScope.launch {
+            snapshotFlow { modifySettingActionBottomSheetState?.settingType }
+                .filterNotNull()
+                .flatMapLatest { settingType ->
+                    val permission = useCase.getRequiredPermissionForSettingType(settingType)
+                    useCase.isPermissionGrantedFlow(permission)
+                }
+                .collectLatest { isGranted ->
+                    modifySettingActionBottomSheetState =
+                        modifySettingActionBottomSheetState?.copy(
+                            isPermissionGranted = isGranted,
+                            testResult = null,
+                        )
+                }
+        }
     }
 
     fun onDoneConfigEnableFlashlightClick() {
@@ -214,12 +235,18 @@ class CreateActionDelegate(
 
     fun onSelectSettingType(settingType: SettingType) {
         modifySettingActionBottomSheetState =
-            modifySettingActionBottomSheetState?.copy(settingType = settingType)
+            modifySettingActionBottomSheetState?.copy(
+                settingType = settingType,
+                testResult = null,
+            )
     }
 
     fun onSettingKeyChange(key: String) {
         modifySettingActionBottomSheetState =
-            modifySettingActionBottomSheetState?.copy(settingKey = key)
+            modifySettingActionBottomSheetState?.copy(
+                settingKey = key,
+                testResult = null,
+            )
     }
 
     fun onChooseExistingSettingClick() {
@@ -233,6 +260,7 @@ class CreateActionDelegate(
                 settingType = setting.settingType,
                 settingKey = setting.key,
                 value = setting.currentValue ?: "",
+                testResult = null,
             )
         }
     }
@@ -242,6 +270,22 @@ class CreateActionDelegate(
             modifySettingActionBottomSheetState?.copy(value = value)
     }
 
+    fun onTestModifySettingClick() {
+        val state = modifySettingActionBottomSheetState ?: return
+
+        coroutineScope.launch {
+            val result = useCase.setSettingValue(state.settingType, state.settingKey, state.value)
+            modifySettingActionBottomSheetState =
+                modifySettingActionBottomSheetState?.copy(testResult = result)
+        }
+    }
+
+    fun onRequestModifySettingPermission() {
+        val state = modifySettingActionBottomSheetState ?: return
+        val permission = useCase.getRequiredPermissionForSettingType(state.settingType)
+        useCase.requestPermission(permission)
+    }
+
     suspend fun editAction(oldData: ActionData) {
         if (!oldData.isEditable()) {
             throw IllegalArgumentException("This action ${oldData.javaClass.name} can't be edited!")

base/src/main/java/io/github/sds100/keymapper/base/actions/CreateActionUseCase.kt

@@ -11,17 +11,20 @@ import io.github.sds100.keymapper.system.permissions.Permission
 import io.github.sds100.keymapper.system.permissions.PermissionAdapter
 import io.github.sds100.keymapper.system.permissions.SystemFeatureAdapter
 import io.github.sds100.keymapper.system.phone.PhoneAdapter
-import javax.inject.Inject
+import io.github.sds100.keymapper.system.settings.SettingType
+import io.github.sds100.keymapper.system.settings.SettingsAdapter
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.first
 import kotlinx.coroutines.flow.merge
+import javax.inject.Inject
 
 class CreateActionUseCaseImpl @Inject constructor(
     private val inputMethodAdapter: InputMethodAdapter,
     private val systemFeatureAdapter: SystemFeatureAdapter,
     private val cameraAdapter: CameraAdapter,
     private val permissionAdapter: PermissionAdapter,
     private val phoneAdapter: PhoneAdapter,
+    private val settingsAdapter: SettingsAdapter,
 ) : CreateActionUseCase,
     IsActionSupportedUseCase by IsActionSupportedUseCaseImpl(
         systemFeatureAdapter,
@@ -69,6 +72,25 @@ class CreateActionUseCaseImpl @Inject constructor(
 
         return phoneAdapter.sendSms(number, message)
     }
+
+    override fun setSettingValue(
+        settingType: SettingType,
+        key: String,
+        value: String,
+    ): KMResult<Unit> {
+        return settingsAdapter.setValue(settingType, key, value)
+    }
+
+    override fun getRequiredPermissionForSettingType(settingType: SettingType): Permission {
+        return when (settingType) {
+            SettingType.SYSTEM -> Permission.WRITE_SETTINGS
+            SettingType.SECURE, SettingType.GLOBAL -> Permission.WRITE_SECURE_SETTINGS
+        }
+    }
+
+    override fun isPermissionGrantedFlow(permission: Permission): Flow<Boolean> {
+        return permissionAdapter.isGrantedFlow(permission)
+    }
 }
 
 interface CreateActionUseCase : IsActionSupportedUseCase {
@@ -83,4 +105,7 @@ interface CreateActionUseCase : IsActionSupportedUseCase {
 
     fun requestPermission(permission: Permission)
     suspend fun testSms(number: String, message: String): KMResult<Unit>
+    fun setSettingValue(settingType: SettingType, key: String, value: String): KMResult<Unit>
+    fun getRequiredPermissionForSettingType(settingType: SettingType): Permission
+    fun isPermissionGrantedFlow(permission: Permission): Flow<Boolean>
 }