Remove aws-sdk dependency (#374)

Co-authored-by: Daniel Cousens <[email protected]>

Author: dcousens

.changeset/made-by-monsters.md

@@ -0,0 +1,5 @@
+---
+'create-keystone-app': patch
+---
+
+Removes `@aws-sdk/util-endpoints` from dependencies as https://github.com/keystonejs/keystone/issues/8023 is resolved

.github/actions/ci-setup/action.yml

@@ -0,0 +1,29 @@
+name: 'CI setup'
+runs:
+  using: 'composite'
+  steps:
+    - name: Setup Node.js LTS
+      uses: actions/setup-node@v3
+      with:
+        # preferably lts/*, but we hit API limits when querying that
+        node-version: 16
+        registry-url: 'https://registry.npmjs.org'
+
+    - name: Get yarn cache directory path
+      id: yarn-cache-dir-path
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+      shell: bash
+
+    - uses: actions/cache@main
+      id: yarn-cache
+      with:
+        path: |
+          ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          node_modules
+        key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+
+    - name: Install Dependencies
+      run: yarn --frozen-lockfile
+      shell: bash

.github/workflows/tests.yml

@@ -20,72 +20,31 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        createProject: ['create project', 'from repo']
+        createProject: ['cka', 'cli']
     steps:
-      - name: Checkout Repo
-        uses: actions/checkout@v3
-
-      - name: Setup Node.js 14.x
-        uses: actions/setup-node@main
-        with:
-          node-version: 14.x
-
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - uses: actions/cache@v3
-        id: yarn-cache
-        with:
-          path: |
-            ${{ steps.yarn-cache-dir-path.outputs.dir }}
-            node_modules
-          key: ${{ runner.os }}-yarn-v5-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-v5-
-
-      - name: Install Dependencies
-        run: yarn
+      - uses: actions/checkout@main
+      - uses: ./.github/actions/ci-setup
 
       - uses: microsoft/playwright-github-action@v1
       - run: node ./node_modules/playwright/install.js
       - name: Tests
         run: yarn jest
         timeout-minutes: 10
         env:
-          CREATE_PROJECT: ${{ matrix.createProject }}
+          TEST_MATRIX_NAME: ${{ matrix.createProject }}
 
   linting:
     name: Linting
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Repo
-        uses: actions/checkout@v3
-
-      - name: Setup Node.js 14.x
-        uses: actions/setup-node@main
-        with:
-          node-version: 14.x
+      - uses: actions/checkout@main
+      - uses: ./.github/actions/ci-setup
 
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - uses: actions/cache@v3
-        id: yarn-cache
-        with:
-          path: |
-            ${{ steps.yarn-cache-dir-path.outputs.dir }}
-            node_modules
-          key: ${{ runner.os }}-yarn-v5-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-v5-
-
-      - name: Install Dependencies
-        run: yarn
       - name: Prettier
         run: yarn lint:prettier
+
       - name: TypeScript
         run: yarn lint:types
+
       - name: Preconstruct
         run: yarn build

create-keystone-app/starter/auth.ts

@@ -39,20 +39,17 @@ const { withAuth } = createAuth({
   sessionData: 'name createdAt',
   secretField: 'password',
 
-  // dont support initFirstItem functionality in production
+  // WARNING: remove initFirstItem functionality in production
   //   see https://keystonejs.com/docs/config/auth#init-first-item for more
-  initFirstItem:
-    process.env.NODE_ENV === 'production'
-      ? undefined
-      : {
-          // if there are no items in the database, by configuring this field
-          //   you are asking the Keystone AdminUI to create a new user
-          //   providing inputs for these fields
-          fields: ['name', 'email', 'password'],
+  initFirstItem: {
+    // if there are no items in the database, by configuring this field
+    //   you are asking the Keystone AdminUI to create a new user
+    //   providing inputs for these fields
+    fields: ['name', 'email', 'password'],
 
-          // it uses context.sudo() to do this, which bypasses any access control you might have
-          //   you shouldn't use this in production
-        },
+    // it uses context.sudo() to do this, which bypasses any access control you might have
+    //   you shouldn't use this in production
+  },
 });
 
 // statelessSessions uses cookies for session tracking

create-keystone-app/starter/package.json

@@ -8,9 +8,7 @@
     "build": "keystone build",
     "postinstall": "keystone postinstall"
   },
-  "// @aws-sdk": "temporary dependency until https://github.com/keystonejs/keystone/issues/8023 is resolved",
   "dependencies": {
-    "@aws-sdk/util-endpoints": "^3.192.0",
     "@keystone-6/auth": "^5.0.0",
     "@keystone-6/core": "^3.0.1",
     "@keystone-6/fields-document": "^5.0.0",