expect greater family of assertions.

* `verify_gt`: verify if `actual` is **greater than** `expected` and return `Result`.
* `assert_gt`: exists in rust: https://docs.rs/all_asserts/latest/all_asserts/macro.assert_gt.html
* `expect_gt`: **logs failure** and **continue execution** if `actual` is **greater than** `expected`.

PiperOrigin-RevId: 649062547

Author: satylogin

googletest/src/assertions.rs

@@ -1000,6 +1000,84 @@ macro_rules! expect_le {
     };
 }
 
+/// Checks whether the first argument is greater than the second argument.
+///
+/// Evaluates to `Result::Ok(())` if the first argument is greater than
+/// the second and `Result::Err(TestAssertionFailure)` if it is not. The
+/// caller must then decide how to handle the `Err` variant. It has a few
+/// options:
+///  * Abort the current function with the `?` operator. This requires that the
+///    function return a suitable `Result`.
+///  * Log the test failure and continue by calling the method
+///    `and_log_failure`.
+///
+/// Of course, one can also use all other standard methods on `Result`.
+///
+/// **Invoking this macro by itself does not cause a test failure to be recorded
+/// or output.** The resulting `Result` must be handled as described above to
+/// cause the test to be recorded as a failure.
+///
+/// Example:
+/// ```ignore
+/// use googletest::prelude::*;
+///
+/// #[test]
+/// fn should_fail() -> Result<()> {
+///     verify_gt!(1, 2)
+/// }
+#[macro_export]
+macro_rules! verify_gt {
+    ($actual:expr, $expected:expr $(,)?) => {
+        verify_that!($actual, $crate::matchers::gt($expected))
+    };
+}
+
+/// Marks test as failed and continues execution if the first argument is
+/// not greater than the second argument.
+///
+/// This is a **not-fatal** failure. The test continues execution even after the
+/// macro execution.
+///
+/// This can only be invoked inside tests with the
+/// [`googletest::test`][crate::test] attribute. The failure must be generated
+/// in the same thread as that running the test itself.
+///
+/// Example:
+/// ```ignore
+/// use googletest::prelude::*;
+///
+/// #[googletest::test]
+/// fn should_fail() {
+///     expect_gt!(1, 2);
+///     println!("This will print!");
+/// }
+/// ```
+///
+/// One may include formatted arguments in the failure message:
+///```ignore
+/// use googletest::prelude::*;
+///
+/// #[googletest::test]
+/// fn should_fail() {
+///     let argument = "argument"
+///     expect_gt!(1, 2, "custom failure message: {argument}");
+///     println!("This will print!");
+/// }
+/// ```
+#[macro_export]
+macro_rules! expect_gt {
+    ($actual:expr, $expected:expr, $($format_args:expr),+ $(,)?) => {
+        use $crate::GoogleTestSupport;
+        verify_gt!($actual, $expected)
+            .with_failure_message(|| format!($($format_args),*))
+            .and_log_failure();
+    };
+    ($actual:expr, $expected:expr $(,)?) => {
+        use $crate::GoogleTestSupport;
+        verify_gt!($actual, $expected).and_log_failure();
+    };
+}
+
 /// Matches the given value against the given matcher, panicking if it does not
 /// match.
 ///

googletest/src/lib.rs

@@ -51,9 +51,9 @@ pub mod prelude {
     // Assert macros
     pub use super::{
         add_failure, add_failure_at, assert_false, assert_that, assert_true, expect_eq,
-        expect_false, expect_le, expect_lt, expect_ne, expect_pred, expect_that, expect_true, fail,
-        succeed, verify_eq, verify_false, verify_le, verify_lt, verify_ne, verify_pred,
-        verify_that, verify_true,
+        expect_false, expect_gt, expect_le, expect_lt, expect_ne, expect_pred, expect_that,
+        expect_true, fail, succeed, verify_eq, verify_false, verify_gt, verify_le, verify_lt,
+        verify_ne, verify_pred, verify_that, verify_true,
     };
 }
 

integration_tests/Cargo.toml

@@ -300,6 +300,21 @@ name = "expect_le_supports_custom_message"
 path = "src/expect_le_supports_custom_message.rs"
 test = false
 
+[[bin]]
+name = "verify_gt_when_not_greater_returns_error"
+path = "src/verify_gt_when_not_greater_returns_error.rs"
+test = false
+
+[[bin]]
+name = "expect_gt_when_not_greater_marks_failed"
+path = "src/expect_gt_when_not_greater_marks_failed.rs"
+test = false
+
+[[bin]]
+name = "expect_gt_supports_custom_message"
+path = "src/expect_gt_supports_custom_message.rs"
+test = false
+
 [[bin]]
 name = "failure_due_to_returned_error_with_line_numbers"
 path = "src/failure_due_to_returned_error_with_line_numbers.rs"

integration_tests/src/expect_gt_supports_custom_message.rs

@@ -0,0 +1,24 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+fn main() {}
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+    #[googletest::test]
+    fn should_fail() {
+        let arg = "argument";
+        expect_gt!(1, 2, "Failure message with argument: {arg}");
+        println!("This will print");
+    }
+}

integration_tests/src/expect_gt_when_not_greater_marks_failed.rs

@@ -0,0 +1,23 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+fn main() {}
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+    #[googletest::test]
+    fn should_fail() {
+        expect_gt!(1, 2);
+        println!("This will print");
+    }
+}

integration_tests/src/integration_tests.rs

@@ -1484,6 +1484,76 @@ mod tests {
         verify_that!(output, contains_regex("This will print"))
     }
 
+    #[test]
+    fn verify_gt_should_pass() -> Result<()> {
+        verify_gt!(2, 1)
+    }
+
+    #[test]
+    fn verify_gt_supports_trailing_comma() -> Result<()> {
+        verify_gt!(2, 1,)
+    }
+
+    #[test]
+    fn verify_gt_when_not_greater_returns_error() -> Result<()> {
+        let output =
+            run_external_process_in_tests_directory("verify_gt_when_not_greater_returns_error")?;
+
+        verify_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is greater than 2
+                Actual: 1,
+                  which is less than or equal to 2
+                  at .*verify_gt_when_not_greater_returns_error.rs:[0-9]+:[0-9]
+            "})
+        )
+    }
+
+    #[googletest::test]
+    fn expect_gt_should_pass() {
+        expect_gt!(2, 1);
+    }
+
+    #[googletest::test]
+    fn expect_gt_supports_trailing_comma() {
+        expect_gt!(2, 1,);
+    }
+
+    #[googletest::test]
+    fn expect_gt_when_not_greater_marks_failed() -> Result<()> {
+        let output =
+            run_external_process_in_tests_directory("expect_gt_when_not_greater_marks_failed")?;
+
+        expect_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is greater than 2
+                Actual: 1,
+                  which is less than or equal to 2
+                  at .*expect_gt_when_not_greater_marks_failed.rs:[0-9]+:[0-9]
+            "})
+        );
+        verify_that!(output, contains_regex("This will print"))
+    }
+
+    #[googletest::test]
+    fn expect_gt_supports_custom_message() -> Result<()> {
+        let output = run_external_process_in_tests_directory("expect_gt_supports_custom_message")?;
+
+        expect_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is greater than 2
+                Actual: 1,
+                  which is less than or equal to 2
+                Failure message with argument: argument
+                  at .*expect_gt_supports_custom_message.rs:[0-9]+:[0-9]
+            "})
+        );
+        verify_that!(output, contains_regex("This will print"))
+    }
+
     #[test]
     fn test_using_normal_test_attribute_macro_formats_failure_message_correctly() -> Result<()> {
         let result = should_display_error_correctly_without_google_test_macro();

integration_tests/src/verify_gt_when_not_greater_returns_error.rs

@@ -0,0 +1,25 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {}
+
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+
+    #[test]
+    fn should_fail() -> Result<()> {
+        verify_gt!(1, 2)
+    }
+}

run_integration_tests.sh

@@ -77,6 +77,9 @@ INTEGRATION_TEST_BINARIES=(
   "verify_le_when_greater_returns_error"
   "expect_le_when_greater_marks_failed"
   "expect_le_supports_custom_message"
+  "verify_gt_when_not_greater_returns_error"
+  "expect_gt_when_not_greater_marks_failed"
+  "expect_gt_supports_custom_message"
   "fatal_and_non_fatal_failure"
   "first_failure_aborts"
   "google_test_with_rstest"