PUBLIC: False boolean conditions macros

Adding rust flavours for:[]
* `verify_false`: check if the given expression is false and returns `Result`.
* `assert_false`: **panics** if the expression evaluates to **true**.
* `expect_false`: **logs failure** and **continues execution** if expression evaluates to
**true**.

PiperOrigin-RevId: 632540641

Author: satylogin

googletest/src/assertions.rs

@@ -523,6 +523,95 @@ macro_rules! expect_true {
     }};
 }
 
+/// Verify if the condition evaluates to false and returns `Result`.
+///
+/// Evaluates to `Result::Ok(())` if the condition is false and
+/// `Result::Err(TestAssertionFailure)` if it evaluates to true. The caller
+/// must then decide how to handle the `Err` variant. It has a few options:
+///   * Abort the current function with the `?` operator. This requires that the
+///     function return a suitable `Result`.
+///   * Log the failure and continue by calling the method `and_log_failure`.
+///
+/// Of course, one can also use all other standard methods on `Result`.
+///
+/// **Invoking this macro by itself does not cause a test failure to be recorded
+/// or output.** The resulting `Result` must be handled as described above to
+/// cause the test to be recorded as a failure.
+///
+/// Example:
+/// ```ignore
+/// use googletest::prelude::*;
+///
+/// #[test]
+/// fn should_fail() -> Result<()> {
+///     verify_false!(2 + 2 == 4)
+/// }
+/// ```
+#[macro_export]
+macro_rules! verify_false {
+    ($condition:expr) => {{
+        use $crate::assertions::internal::Subject;
+        ($condition).check(
+            $crate::matchers::eq(false),
+            stringify!($condition),
+            $crate::internal::source_location::SourceLocation::new(file!(), line!(), column!()),
+        )
+    }};
+}
+
+/// Assert if the condition evaluates to false and panics if true.
+///
+/// This is the same as calling `and_log_failure` on [`verify_false`] macro
+/// Result.
+///
+/// This can only be invoked inside tests with the
+/// [`googletest::test`][crate::test] attribute. The failure must be generated
+/// in the same thread as that running the thread itself.
+///
+/// Example:
+/// ```ignore
+/// use googletest::prelude::*;
+///
+/// #[googletest::test]
+/// fn should_fail() {
+///     assert_false!(2 + 2 == 4);
+/// }
+/// ```
+#[macro_export]
+macro_rules! assert_false {
+    ($condition:expr) => {
+        verify_false!($condition).and_log_failure()
+    };
+}
+
+/// Marks test as failed and continue execution if the expression evaluates to
+/// true.
+///
+/// This is a **not-fatal** failure. The test continues execution even after the
+/// macro execution.
+///
+/// This can only be invoked inside tests with the
+/// [`googletest::test`][crate::test] attribute. The failure must be generated
+/// in the same thread as that running the thread itself.
+///
+/// Example:
+/// ```ignore
+/// use googletest::prelude::*;
+///
+/// #[googletest::test]
+/// fn should_fail() {
+///     expect_false!(2 + 2 == 4);
+///     println!("This will print");
+/// }
+/// ```
+#[macro_export]
+macro_rules! expect_false {
+    ($condition:expr) => {{
+        use $crate::GoogleTestSupport;
+        verify_false!($condition).and_log_failure()
+    }};
+}
+
 /// Matches the given value against the given matcher, panicking if it does not
 /// match.
 ///

googletest/src/lib.rs

@@ -50,8 +50,9 @@ pub mod prelude {
     pub use super::Result;
     // Assert macros
     pub use super::{
-        add_failure, add_failure_at, assert_that, assert_true, expect_pred, expect_that,
-        expect_true, fail, succeed, verify_pred, verify_that, verify_true,
+        add_failure, add_failure_at, assert_false, assert_that, assert_true, expect_false,
+        expect_pred, expect_that, expect_true, fail, succeed, verify_false, verify_pred,
+        verify_that, verify_true,
     };
 }
 

integration_tests/Cargo.toml

@@ -160,6 +160,21 @@ name = "expect_true_macro_on_false_condition_fails_test_and_continues"
 path = "src/expect_true_macro_on_false_condition_fails_test_and_continues.rs"
 test = false
 
+[[bin]]
+name = "verify_false_macro_on_true_condition"
+path = "src/verify_false_macro_on_true_condition.rs"
+test = false
+
+[[bin]]
+name = "assert_false_macro_on_true_condition_panics"
+path = "src/assert_false_macro_on_true_condition_panics.rs"
+test = false
+
+[[bin]]
+name = "expect_false_macro_on_true_condition_fails_test_and_continues"
+path = "src/expect_false_macro_on_true_condition_fails_test_and_continues.rs"
+test = false
+
 [[bin]]
 name = "failure_due_to_returned_error"
 path = "src/failure_due_to_returned_error.rs"

integration_tests/src/assert_false_macro_on_true_condition_panics.rs

@@ -0,0 +1,25 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {}
+
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+
+    #[googletest::test]
+    fn should_fail() {
+        assert_false!(2 + 2 == 4);
+    }
+}

integration_tests/src/expect_false_macro_on_true_condition_fails_test_and_continues.rs

@@ -0,0 +1,26 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {}
+
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+
+    #[googletest::test]
+    fn should_fail() {
+        expect_false!(2 + 2 == 4);
+        println!("This will print");
+    }
+}

integration_tests/src/integration_tests.rs

@@ -777,6 +777,76 @@ mod tests {
         verify_that!(output, contains_regex("This will print"))
     }
 
+    #[test]
+    fn verify_false_when_false_returns_ok() {
+        assert!(verify_false!("test" == "not test").is_ok())
+    }
+
+    #[test]
+    fn verify_false_when_true_returns_err() {
+        assert!(verify_false!(2 + 2 == 4).is_err())
+    }
+
+    #[googletest::test]
+    fn verify_false_macro_on_true_condition_logs_error_when_handled() -> Result<()> {
+        let output =
+            run_external_process_in_tests_directory("verify_false_macro_on_true_condition")?;
+
+        verify_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is equal to false
+                Actual: true,
+                  which isn't equal to false
+                  at .*verify_false_macro_on_true_condition.rs:23:9
+                "})
+        )
+    }
+
+    #[googletest::test]
+    fn assert_false_macro_on_false_condition_does_nothing() {
+        assert_false!(2 + 2 == 5);
+    }
+
+    #[googletest::test]
+    fn assert_false_macro_on_true_condition_panics() -> Result<()> {
+        let output =
+            run_external_process_in_tests_directory("assert_false_macro_on_true_condition_panics")?;
+
+        verify_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is equal to false
+                Actual: true,
+                  which isn't equal to false
+                  at .*assert_false_macro_on_true_condition_panics.rs:23:9
+                "})
+        )
+    }
+
+    #[googletest::test]
+    fn expect_false_macro_on_false_condition_does_nothing() {
+        expect_false!(2 + 2 == 5)
+    }
+
+    #[googletest::test]
+    fn expect_false_macro_on_true_condition_fails_test_and_continues() -> Result<()> {
+        let output = run_external_process_in_tests_directory(
+            "expect_false_macro_on_true_condition_fails_test_and_continues",
+        )?;
+
+        expect_that!(
+            output,
+            contains_regex(indoc! {"
+                Expected: is equal to false
+                Actual: true,
+                  which isn't equal to false
+                  at .*expect_false_macro_on_true_condition_fails_test_and_continues.rs:23:9
+                "})
+        );
+        verify_that!(output, contains_regex("This will print"))
+    }
+
     #[test]
     fn test_using_normal_test_attribute_macro_formats_failure_message_correctly() -> Result<()> {
         let result = should_display_error_correctly_without_google_test_macro();

integration_tests/src/verify_false_macro_on_true_condition.rs

@@ -0,0 +1,25 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+fn main() {}
+
+#[cfg(test)]
+mod tests {
+    use googletest::prelude::*;
+
+    #[test]
+    fn should_fail() -> Result<()> {
+        verify_false!(2 + 2 == 4)
+    }
+}

run_integration_tests.sh

@@ -49,6 +49,9 @@ INTEGRATION_TEST_BINARIES=(
   "verify_true_macro_on_false_condition"
   "assert_true_macro_on_false_condition_panics"
   "expect_true_macro_on_false_condition_fails_test_and_continues"
+  "verify_false_macro_on_true_condition"
+  "assert_false_macro_on_true_condition_panics"
+  "expect_false_macro_on_true_condition_fails_test_and_continues"
   "fatal_and_non_fatal_failure"
   "first_failure_aborts"
   "google_test_with_rstest"