refactor data repository (#51)

add more tests

Author: Gsantomaggio

cmd/tools/cli/integration_test.go

@@ -46,3 +46,47 @@ func TestDelete(t *testing.T) {
 	}
 	assertMessage(t, out.String(), `service "argo-server" deleted`)
 }
+
+func TestLocalApply(t *testing.T) {
+	cmd, out := setUp()
+	cmd.SetArgs([]string{"apply", "argo-workflow-ns", "--kubectl", "--plugin-repo", joinWithRootData("plugins")})
+	if err := cmd.Execute(); err != nil {
+		t.Fatalf("unexpected error %v", err)
+	}
+	assertMessage(t, out.String(), `service/argo-server created`)
+}
+
+func TestLocalDelete(t *testing.T) {
+	cmd, out := setUp()
+	cmd.SetArgs([]string{"delete", "argo-workflow-ns", "--kubectl", "--plugin-repo", joinWithRootData("plugins")})
+	if err := cmd.Execute(); err != nil {
+		t.Fatalf("unexpected error %v", err)
+	}
+	assertMessage(t, out.String(), `service "argo-server" deleted`)
+}
+
+func TestLocalGroupApply(t *testing.T) {
+	cmd, out := setUp()
+	cmd.SetArgs([]string{"apply", "-g", "argo", "--kubectl", "--group-repo", joinWithRootData("groups")})
+	if err := cmd.Execute(); err != nil {
+		t.Fatalf("unexpected error %v", err)
+	}
+	assertMessage(t, out.String(), `service/argo-server created`)
+}
+
+func TestLocalGroupDelete(t *testing.T) {
+	cmd, out := setUp()
+	cmd.SetArgs([]string{"delete", "-g", "argo", "--kubectl", "--group-repo", joinWithRootData("groups")})
+	if err := cmd.Execute(); err != nil {
+		t.Fatalf("unexpected error %v", err)
+	}
+	assertMessage(t, out.String(), `service "argo-server" deleted`)
+}
+
+func getRootTestData() string {
+	return "../../../local_repo/core/"
+}
+
+func joinWithRootData(fileURI string) string {
+	return getRootTestData() + fileURI
+}

internal/plugins/groups_test.go

@@ -7,7 +7,7 @@ import (
 
 func TestValidatePluginsGroupSpec(t *testing.T) {
 	var group Group
-	testPluginsGroupsSpec, err := group.Encode("testdata/groups/two_plugins/group.yaml")
+	testPluginsGroupsSpec, err := group.Encode(joinWithRootData("groups/argo/group.yaml"))
 
 	if err != nil {
 		t.Fatalf("failed to unmarshal test file: %s", err)

internal/plugins/plugins_test.go

@@ -7,7 +7,7 @@ import (
 
 func TestValidate(t *testing.T) {
 	var p Plugin
-	testPluginSpec, err := p.Encode("testdata/defaults/plugin.yaml")
+	testPluginSpec, err := p.Encode(joinWithRootData("plugins/argo-workflow-ns/plugin.yaml"))
 
 	if err != nil {
 		t.Fatal("failed to unmarshal test file")
@@ -28,7 +28,7 @@ func TestValidate(t *testing.T) {
 
 func TestValidateDefaultValues(t *testing.T) {
 	var p Plugin
-	testPluginSpec, err := p.Encode("testdata/empty_defaults/plugin.yaml")
+	testPluginSpec, err := p.Encode(joinWithRootData("plugins/argo-workflow-no-defaults/plugin.yaml"))
 	if err != nil {
 		t.Fatal("failed to unmarshal test file")
 	}

internal/plugins/remote_contents_test.go

@@ -28,7 +28,7 @@ func mockPluginsServer(t *testing.T, filePath string, contentType string) *httpt
 }
 
 func TestPluginsList(t *testing.T) {
-	var server = mockPluginsServer(t, "testdata/defaults/plugin.yaml", PluginType)
+	var server = mockPluginsServer(t, joinWithRootData("plugins/argo-workflow-ns/plugin.yaml"), PluginType)
 	defer server.Close()
 	p, err := ContentList(server.URL)
 	if err != nil {
@@ -40,7 +40,7 @@ func TestPluginsList(t *testing.T) {
 }
 
 func TestPluginYamls(t *testing.T) {
-	var server = mockPluginsServer(t, "testdata/defaults/plugin.yaml", PluginType)
+	var server = mockPluginsServer(t, joinWithRootData("plugins/argo-workflow-ns/plugin.yaml"), PluginType)
 	defer server.Close()
 	var pluginList Plugins
 
@@ -55,7 +55,7 @@ func TestPluginYamls(t *testing.T) {
 }
 
 func TestGroupsYamls(t *testing.T) {
-	var server = mockPluginsServer(t, "testdata/groups/two_plugins/group.yaml", GroupType)
+	var server = mockPluginsServer(t, joinWithRootData("groups/argo/group.yaml"), GroupType)
 	defer server.Close()
 	var groups Groups
 	r, err := groups.Encode(server.URL, "/test")

internal/plugins/shared_test.go

@@ -0,0 +1,9 @@
+package plugins
+
+func getRootTestData() string {
+	return "../../local_repo/core/"
+}
+
+func joinWithRootData(fileURI string) string {
+	return getRootTestData() + fileURI
+}

internal/plugins/testdata/empty_defaults/plugin.yaml

@@ -0,0 +1,5 @@
+plugin-type: group
+group-name: only-argo
+plugins:
+  - name: argo
+    enabled: true

internal/plugins/testdata/groups/two_plugins/group.yaml

@@ -3,6 +3,8 @@ namespace: "argo"
 yaml:
   - url: "https://raw.githubusercontent.com/argoproj/argo/stable/manifests/namespace-install.yaml"
     type: "file"
+  - url: "https://raw.githubusercontent.com/kf5i/k3ai-plugins/main/common/traefik/argo-bind.yaml"
+    type: "file"
 bash:
   - bashfile1
   - bashfile2