Conversation
Owner
Author
|
@assignUser Hey - hope you're well. A unit test was generating a CRAN error, and they gave me a couple of weeks to update on CRAN. I fixed it by adding a seed and am ready to upload. There's no real need for you to verify, but you certainly can take a look. I'll wait until Monday. |
Collaborator
|
Setting a seed is sensible here, after all you are not testing the underlying numerical implementation (which is causing the differences here with MKL). Hopefully this seed also works on the MKL test 🤞 |
Owner
Author
|
Yeah - that would be a shocker. But, I change the sample size to 2500 and tested 10000 runs (with no seed :)) and all tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.