Skip to content

Commit d3e94f2

Browse files
committed
fix: 코드래빗 리뷰 반영
1 parent 7ef6480 commit d3e94f2

17 files changed

Lines changed: 57 additions & 57 deletions

File tree

aics-admin/src/main/java/kgu/developers/admin/graduationUser/presentation/GraduationUserAdminControllerImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ public ResponseEntity<GraduationUserPersistResponse> createGraduationUser(
8888

8989
@Override
9090
@PostMapping("/batch")
91-
public ResponseEntity<GraduationUserBatchCreateResponse> createGraduationUsers(GraduationUserBatchCreateRequest request) {
91+
public ResponseEntity<GraduationUserBatchCreateResponse> createGraduationUsers(
92+
@Valid @RequestBody GraduationUserBatchCreateRequest request
93+
) {
9294
GraduationUserBatchCreateResponse response = graduationUserAdminFacade.createGraduationUsers(request);
9395
return ResponseEntity.status(CREATED).body(response);
9496
}

aics-admin/src/main/java/kgu/developers/admin/graduationUser/presentation/request/GraduationUserBatchCreateRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
@Builder
1212
public record GraduationUserBatchCreateRequest(
13-
@Schema(description = "게시글 정보 리스트",
13+
@Schema(description = "졸업 대상자 생성 리스트",
1414
example = "[{"
1515
+ "\"studentId\": \"202211461\", "
1616
+ "\"name\": \"홍길동\", "

aics-admin/src/main/java/kgu/developers/admin/graduationUser/presentation/response/GraduationUserDetailResponse.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public record GraduationUserDetailResponse(
2222

2323
@Schema(description = "졸업 날짜", example = "2028-08-01", requiredMode = REQUIRED)
2424
@DateTimeFormat(pattern = "yyyy-MM-dd")
25-
String graduaionDate,
25+
String graduationDate,
2626

2727
@Schema(description = "지도교수", example = "김교수", requiredMode = REQUIRED)
2828
String advisor,
@@ -41,7 +41,7 @@ public static GraduationUserDetailResponse from(
4141
.graduationUserId(graduationUser.getId())
4242
.name(graduationUser.getName())
4343
.studentId(graduationUser.getUserId())
44-
.graduaionDate(graduationUser.getGraduationDate().format(formatter))
44+
.graduationDate(graduationUser.getGraduationDate().format(formatter))
4545
.advisor(graduationUser.getAdvisorProfessor())
4646
.major(graduationUser.getDepartment())
4747
.capstoneCompletion(graduationUser.getCapstoneCompletion())

aics-admin/src/main/java/kgu/developers/admin/graduationUser/presentation/response/GraduationUserSummaryPageResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public record GraduationUserSummaryPageResponse<T>(
1616
+ "\"id\": 3, "
1717
+ "\"studentId\": \"202211456\", "
1818
+ "\"name\": \"홍길동\", "
19-
+ "\"graduaionDate\": \"2028-08-01\", "
19+
+ "\"graduationDate\": \"2028-08-01\", "
2020
+ "\"graduationType\": \"자격증\", "
2121
+ "\"status\": \"미제출\"}]",
2222
requiredMode = REQUIRED)

aics-admin/src/main/java/kgu/developers/admin/graduationUser/presentation/response/GraduationUserSummaryResponse.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public record GraduationUserSummaryResponse(
2222

2323
@Schema(description = "졸업 날짜", example = "2028-08-01", requiredMode = REQUIRED)
2424
@DateTimeFormat(pattern = "yyyy-MM-dd")
25-
String graduaionDate,
25+
String graduationDate,
2626

2727
@Schema(description = "졸업 유형", example = "자격증", requiredMode = REQUIRED)
2828
String graduationType,
@@ -37,7 +37,7 @@ public static GraduationUserSummaryResponse from(GraduationUser graduationUser)
3737
.id(graduationUser.getId())
3838
.studentId(graduationUser.getUserId())
3939
.name(graduationUser.getName())
40-
.graduaionDate(graduationUser.getGraduationDate().format(formatter))
40+
.graduationDate(graduationUser.getGraduationDate().format(formatter))
4141
.graduationType(graduationUser.getGraduationType() != null ? graduationUser.getGraduationType().getDescription() : "미정")
4242
.status("") //TODO: Thesis, Certificate관련 로직이 추가되면 변경하여야 합니다.
4343
.build();

aics-admin/src/testFixtures/java/graduationUser/application/GraduationUserAdminFacadeTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import kgu.developers.domain.graduationUser.domain.GraduationUser;
1515
import kgu.developers.domain.graduationUser.domain.GraduationUserExcel;
1616
import kgu.developers.domain.graduationUser.infrastructure.excel.GraduationUserExcelImpl;
17-
import mock.repository.FakeGraduatoinUserRepository;
17+
import mock.repository.FakeGraduationUserRepository;
1818
import org.junit.jupiter.api.BeforeEach;
1919
import org.junit.jupiter.api.DisplayName;
2020
import org.junit.jupiter.api.Test;
@@ -35,18 +35,18 @@ public class GraduationUserAdminFacadeTest {
3535

3636
@BeforeEach
3737
public void init() {
38-
FakeGraduatoinUserRepository fakeGraduatoinUserRepository = new FakeGraduatoinUserRepository();
39-
GraduationUserCommandService graduationUserCommandService = new GraduationUserCommandService(fakeGraduatoinUserRepository);
38+
FakeGraduationUserRepository fakeGraduationUserRepository = new FakeGraduationUserRepository();
39+
GraduationUserCommandService graduationUserCommandService = new GraduationUserCommandService(fakeGraduationUserRepository);
4040

4141
GraduationUserExcel graduationUserExcel = new GraduationUserExcelImpl();
42-
GraduationUserQueryService graduationUserQueryService = new GraduationUserQueryService(fakeGraduatoinUserRepository,graduationUserExcel);
42+
GraduationUserQueryService graduationUserQueryService = new GraduationUserQueryService(fakeGraduationUserRepository,graduationUserExcel);
4343

4444
graduationUserAdminFacade = new GraduationUserAdminFacade(
4545
graduationUserCommandService,
4646
graduationUserQueryService
4747
);
4848

49-
graduationUser1 = fakeGraduatoinUserRepository.save(GraduationUser.builder()
49+
graduationUser1 = fakeGraduationUserRepository.save(GraduationUser.builder()
5050
.id(1L)
5151
.name("홍길동")
5252
.userId("202411001")
@@ -55,7 +55,7 @@ public void init() {
5555
.graduationDate(LocalDate.of(2021, 12, 31))
5656
.build());
5757

58-
graduationUser2 = fakeGraduatoinUserRepository.save(GraduationUser.builder()
58+
graduationUser2 = fakeGraduationUserRepository.save(GraduationUser.builder()
5959
.id(2L)
6060
.name("이영희")
6161
.userId("202411002")
@@ -64,7 +64,7 @@ public void init() {
6464
.graduationDate(LocalDate.of(2021, 12, 31))
6565
.build());
6666

67-
fakeGraduatoinUserRepository.save(GraduationUser.builder()
67+
fakeGraduationUserRepository.save(GraduationUser.builder()
6868
.id(3L)
6969
.name("이지민")
7070
.userId("202411003")

aics-api/src/main/java/kgu/developers/api/graduationUser/application/GraduationuserFacade.java renamed to aics-api/src/main/java/kgu/developers/api/graduationUser/application/GraduationUserFacade.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
@Component
1313
@Transactional
1414
@RequiredArgsConstructor
15-
public class GraduationuserFacade {
15+
public class GraduationUserFacade {
1616
private final GraduationUserQueryService graduationUserQueryService;
1717
private final GraduationUserCommandService graduationUserCommandService;
1818
private final UserQueryService userQueryService;

aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/GraduationUserController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import jakarta.validation.Valid;
88
import jakarta.validation.constraints.Positive;
99
import kgu.developers.api.graduationUser.presentation.request.GraduationTypeUpdateRequest;
10-
import kgu.developers.api.graduationUser.presentation.request.GraduationUseEmailUpdateRequest;
10+
import kgu.developers.api.graduationUser.presentation.request.GraduationUserEmailUpdateRequest;
1111
import org.springframework.http.ResponseEntity;
1212
import org.springframework.web.bind.annotation.PathVariable;
1313
import org.springframework.web.bind.annotation.RequestBody;
@@ -45,6 +45,6 @@ ResponseEntity<Void> updateGraduationUserEmail(
4545
@Parameter(
4646
description = "졸업 대상자 request 객체 입니다.",
4747
required = true
48-
) @Valid @RequestBody GraduationUseEmailUpdateRequest request
48+
) @Valid @RequestBody GraduationUserEmailUpdateRequest request
4949
);
5050
}

aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/GraduationUserControllerImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import jakarta.validation.Valid;
44
import jakarta.validation.constraints.Positive;
5-
import kgu.developers.api.graduationUser.application.GraduationuserFacade;
5+
import kgu.developers.api.graduationUser.application.GraduationUserFacade;
66
import kgu.developers.api.graduationUser.presentation.request.GraduationTypeUpdateRequest;
7-
import kgu.developers.api.graduationUser.presentation.request.GraduationUseEmailUpdateRequest;
7+
import kgu.developers.api.graduationUser.presentation.request.GraduationUserEmailUpdateRequest;
88
import lombok.RequiredArgsConstructor;
99
import org.springframework.http.ResponseEntity;
1010
import org.springframework.security.access.prepost.PreAuthorize;
@@ -20,7 +20,7 @@
2020
@RequestMapping("/api/v1/graduation-users")
2121
public class GraduationUserControllerImpl implements GraduationUserController {
2222

23-
private final GraduationuserFacade graduationuserFacade;
23+
private final GraduationUserFacade graduationuserFacade;
2424

2525
@Override
2626
@PatchMapping("/{graduationUserId}/graduation-type")
@@ -35,7 +35,7 @@ public ResponseEntity<Void> selectGraduationType(
3535
@PatchMapping("/{graduationUserId}/email")
3636
public ResponseEntity<Void> updateGraduationUserEmail(
3737
@Positive @PathVariable Long graduationUserId,
38-
@Valid @RequestBody GraduationUseEmailUpdateRequest request) {
38+
@Valid @RequestBody GraduationUserEmailUpdateRequest request) {
3939
graduationuserFacade.updateGraduationUserEmail(graduationUserId,request.email());
4040
return ResponseEntity.noContent().build();
4141
}

aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/request/GraduationUseEmailUpdateRequest.java renamed to aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/request/GraduationUserEmailUpdateRequest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package kgu.developers.api.graduationUser.presentation.request;
22

33
import io.swagger.v3.oas.annotations.media.Schema;
4+
import jakarta.validation.constraints.NotBlank;
45
import jakarta.validation.constraints.Pattern;
56

67
import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED;
78

8-
public record GraduationUseEmailUpdateRequest(
9+
public record GraduationUserEmailUpdateRequest(
910
@Schema(description = "이메일", example = "qkralswnsWkd@kyonggi.ac.kr", requiredMode = REQUIRED)
1011
@Pattern(regexp = "^[A-Za-z0-9._%+-]+@(kyonggi|kgu)\\.ac\\.kr$", message = "학교 이메일 형식으로 입력해주세요.")
12+
@NotBlank(message = "이메일은 필수 값입니다.")
1113
String email
1214
) {
1315
}

0 commit comments

Comments
 (0)