Skip to content

Commit 0a797db

Browse files
Alexander Duyckdavem330
authored andcommitted
i40e/i40evf: Update DESC_NEEDED value to reflect larger value
When compared to ixgbe and other previous Intel drivers the i40e and i40evf drivers actually reserve 2 additional descriptors in maybe_stop_tx for cache line alignment. We need to update DESC_NEEDED to reflect this as otherwise we are more likely to return TX_BUSY which will cause issues with things like xmit_more. Signed-off-by: Alexander Duyck <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0bc0b97 commit 0a797db

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

drivers/net/ethernet/intel/i40e/i40e_txrx.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ static inline unsigned int i40e_txd_use_count(unsigned int size)
279279
}
280280

281281
/* Tx Descriptors needed, worst case */
282-
#define DESC_NEEDED (MAX_SKB_FRAGS + 4)
282+
#define DESC_NEEDED (MAX_SKB_FRAGS + 6)
283283
#define I40E_MIN_DESC_PENDING 4
284284

285285
#define I40E_TX_FLAGS_HW_VLAN BIT(1)

drivers/net/ethernet/intel/i40evf/i40e_txrx.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static inline unsigned int i40e_txd_use_count(unsigned int size)
260260
}
261261

262262
/* Tx Descriptors needed, worst case */
263-
#define DESC_NEEDED (MAX_SKB_FRAGS + 4)
263+
#define DESC_NEEDED (MAX_SKB_FRAGS + 6)
264264
#define I40E_MIN_DESC_PENDING 4
265265

266266
#define I40E_TX_FLAGS_HW_VLAN BIT(1)

0 commit comments

Comments
 (0)