Skip to content

Commit 139dd0e

Browse files
praritlenb
authored andcommitted
tools/power turbostat: rename num_cores_per_pkg to num_cores_per_node
turbostat incorrectly assumes that there is one node per package. As a result num_cores_per_pkg is not correctly named and is actually num_cores_per_node. Rename num_cores_per_pkg to num_cores_per_node. Signed-off-by: Prarit Bhargava <[email protected]> Signed-off-by: Len Brown <[email protected]>
1 parent 8cb48b3 commit 139dd0e

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

tools/power/x86/turbostat/turbostat.c

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,11 @@ struct pkg_data {
217217
#define EVEN_COUNTERS thread_even, core_even, package_even
218218

219219
#define GET_THREAD(thread_base, thread_no, core_no, pkg_no) \
220-
(thread_base + (pkg_no) * topo.num_cores_per_pkg * \
220+
(thread_base + (pkg_no) * topo.num_cores_per_node * \
221221
topo.num_threads_per_core + \
222222
(core_no) * topo.num_threads_per_core + (thread_no))
223223
#define GET_CORE(core_base, core_no, pkg_no) \
224-
(core_base + (pkg_no) * topo.num_cores_per_pkg + (core_no))
224+
(core_base + (pkg_no) * topo.num_cores_per_node + (core_no))
225225
#define GET_PKG(pkg_base, pkg_no) (pkg_base + pkg_no)
226226

227227
enum counter_scope {SCOPE_CPU, SCOPE_CORE, SCOPE_PACKAGE};
@@ -274,7 +274,7 @@ struct topo_params {
274274
int max_cpu_num;
275275
int max_node_num;
276276
int num_nodes_per_pkg;
277-
int num_cores_per_pkg;
277+
int num_cores_per_node;
278278
int num_threads_per_core;
279279
} topo;
280280

@@ -300,7 +300,8 @@ int for_all_cpus(int (func)(struct thread_data *, struct core_data *, struct pkg
300300
int retval, pkg_no, core_no, thread_no;
301301

302302
for (pkg_no = 0; pkg_no < topo.num_packages; ++pkg_no) {
303-
for (core_no = 0; core_no < topo.num_cores_per_pkg; ++core_no) {
303+
for (core_no = 0; core_no < topo.num_cores_per_node;
304+
++core_no) {
304305
for (thread_no = 0; thread_no <
305306
topo.num_threads_per_core; ++thread_no) {
306307
struct thread_data *t;
@@ -2491,7 +2492,8 @@ int for_all_cpus_2(int (func)(struct thread_data *, struct core_data *,
24912492
int retval, pkg_no, core_no, thread_no;
24922493

24932494
for (pkg_no = 0; pkg_no < topo.num_packages; ++pkg_no) {
2494-
for (core_no = 0; core_no < topo.num_cores_per_pkg; ++core_no) {
2495+
for (core_no = 0; core_no < topo.num_cores_per_node;
2496+
++core_no) {
24952497
for (thread_no = 0; thread_no <
24962498
topo.num_threads_per_core; ++thread_no) {
24972499
struct thread_data *t, *t2;
@@ -4728,11 +4730,11 @@ void topology_probe()
47284730
cpus[i].thread_id);
47294731
}
47304732

4731-
topo.num_cores_per_pkg = max_core_id + 1;
4733+
topo.num_cores_per_node = max_core_id + 1;
47324734
if (debug > 1)
47334735
fprintf(outf, "max_core_id %d, sizing for %d cores per package\n",
4734-
max_core_id, topo.num_cores_per_pkg);
4735-
if (!summary_only && topo.num_cores_per_pkg > 1)
4736+
max_core_id, topo.num_cores_per_node);
4737+
if (!summary_only && topo.num_cores_per_node > 1)
47364738
BIC_PRESENT(BIC_Core);
47374739

47384740
topo.num_packages = max_package_id + 1;
@@ -4756,21 +4758,21 @@ allocate_counters(struct thread_data **t, struct core_data **c, struct pkg_data
47564758
{
47574759
int i;
47584760

4759-
*t = calloc(topo.num_threads_per_core * topo.num_cores_per_pkg *
4761+
*t = calloc(topo.num_threads_per_core * topo.num_cores_per_node *
47604762
topo.num_packages, sizeof(struct thread_data));
47614763
if (*t == NULL)
47624764
goto error;
47634765

47644766
for (i = 0; i < topo.num_threads_per_core *
4765-
topo.num_cores_per_pkg * topo.num_packages; i++)
4767+
topo.num_cores_per_node * topo.num_packages; i++)
47664768
(*t)[i].cpu_id = -1;
47674769

4768-
*c = calloc(topo.num_cores_per_pkg * topo.num_packages,
4770+
*c = calloc(topo.num_cores_per_node * topo.num_packages,
47694771
sizeof(struct core_data));
47704772
if (*c == NULL)
47714773
goto error;
47724774

4773-
for (i = 0; i < topo.num_cores_per_pkg * topo.num_packages; i++)
4775+
for (i = 0; i < topo.num_cores_per_node * topo.num_packages; i++)
47744776
(*c)[i].core_id = -1;
47754777

47764778
*p = calloc(topo.num_packages, sizeof(struct pkg_data));

0 commit comments

Comments
 (0)