Skip to content

Commit 14b4dba

Browse files
rmurphy-armwildea01
authored andcommitted
Revert "iommu/arm-smmu: Set PRIVCFG in stage 1 STEs"
This reverts commit df5e1a0f2a2d779ad467a691203bcbc74d75690e. Now that proper privileged mappings can be requested via IOMMU_PRIV, unconditionally overriding the incoming PRIVCFG becomes the wrong thing to do, so stop it. Signed-off-by: Robin Murphy <[email protected]> Signed-off-by: Will Deacon <[email protected]>
1 parent e198980 commit 14b4dba

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/iommu/arm-smmu-v3.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,6 @@
269269
#define STRTAB_STE_1_SHCFG_INCOMING 1UL
270270
#define STRTAB_STE_1_SHCFG_SHIFT 44
271271

272-
#define STRTAB_STE_1_PRIVCFG_UNPRIV 2UL
273-
#define STRTAB_STE_1_PRIVCFG_SHIFT 48
274-
275272
#define STRTAB_STE_2_S2VMID_SHIFT 0
276273
#define STRTAB_STE_2_S2VMID_MASK 0xffffUL
277274
#define STRTAB_STE_2_VTCR_SHIFT 32
@@ -1073,9 +1070,7 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_device *smmu, u32 sid,
10731070
#ifdef CONFIG_PCI_ATS
10741071
STRTAB_STE_1_EATS_TRANS << STRTAB_STE_1_EATS_SHIFT |
10751072
#endif
1076-
STRTAB_STE_1_STRW_NSEL1 << STRTAB_STE_1_STRW_SHIFT |
1077-
STRTAB_STE_1_PRIVCFG_UNPRIV <<
1078-
STRTAB_STE_1_PRIVCFG_SHIFT);
1073+
STRTAB_STE_1_STRW_NSEL1 << STRTAB_STE_1_STRW_SHIFT);
10791074

10801075
if (smmu->features & ARM_SMMU_FEAT_STALLS)
10811076
dst[1] |= cpu_to_le64(STRTAB_STE_1_S1STALLD);

0 commit comments

Comments
 (0)