Skip to content

Commit 4b707fa

Browse files
agnersolofj
authored andcommitted
ARM: dts: imx7d: fix LCDIF clock assignment
The eLCDIF IP of the i.MX 7 SoC knows multiple clocks and lists them separately: Clock Clock Root Description apb_clk MAIN_AXI_CLK_ROOT AXI clock pix_clk LCDIF_PIXEL_CLK_ROOT Pixel clock ipg_clk_s MAIN_AXI_CLK_ROOT Peripheral access clock All of them are switched by a single gate, which is part of the IMX7D_LCDIF_PIXEL_ROOT_CLK clock. Hence using that clock also for the AXI bus clock (clock-name "axi") makes sure the gate gets enabled when accessing registers. There seem to be no separate AXI display clock, and the clock is optional. Hence remove the dummy clock. This fixes kernel freezes when starting the X-Server (which disables/re-enables the display controller). Fixes: e8ed73f ("ARM: dts: imx7d: add lcdif support") Signed-off-by: Stefan Agner <[email protected]> Reviewed-by: Fabio Estevam <[email protected]> Acked-by: Shawn Guo <[email protected]> Signed-off-by: Olof Johansson <[email protected]>
1 parent 4367c1d commit 4b707fa

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

arch/arm/boot/dts/imx7s.dtsi

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -643,9 +643,8 @@
643643
reg = <0x30730000 0x10000>;
644644
interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
645645
clocks = <&clks IMX7D_LCDIF_PIXEL_ROOT_CLK>,
646-
<&clks IMX7D_CLK_DUMMY>,
647-
<&clks IMX7D_CLK_DUMMY>;
648-
clock-names = "pix", "axi", "disp_axi";
646+
<&clks IMX7D_LCDIF_PIXEL_ROOT_CLK>;
647+
clock-names = "pix", "axi";
649648
status = "disabled";
650649
};
651650
};

0 commit comments

Comments
 (0)