Skip to content

Commit 4ba9bf9

Browse files
Georgi Djakovstorulf
authored andcommitted
mmc: sdhci-msm: Remove NO_CARD_NO_RESET quirk
Now we have a proper implementation for the power irq handling and this quirk is not needed anymore. In fact, it is causing card detection delays on apq8096 platforms and the following error is displayed: sdhci_msm 74a4900.sdhci: mmc0: pwr_irq for req: (4) timed out The quirk is forcing the controller to retain 1.8V signalling on the slot even when a new card is inserted, which is not correct. The proper behavior would be to reset the controller in order to start with 3.3V signaling. Fixes: c0309b3 ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq") Suggested-by: Vijay Viswanath <[email protected]> Signed-off-by: Georgi Djakov <[email protected]> Acked-by: Adrian Hunter <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent af6b8ff commit 4ba9bf9

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/mmc/host/sdhci-msm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1412,7 +1412,6 @@ static const struct sdhci_ops sdhci_msm_ops = {
14121412

14131413
static const struct sdhci_pltfm_data sdhci_msm_pdata = {
14141414
.quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
1415-
SDHCI_QUIRK_NO_CARD_NO_RESET |
14161415
SDHCI_QUIRK_SINGLE_POWER_WRITE |
14171416
SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
14181417
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,

0 commit comments

Comments
 (0)