Skip to content

Commit 589b754

Browse files
geerturobherring
authored andcommitted
of: overlay: Make node skipping in init_overlay_changeset() clearer
Make it more clear that nodes without "__overlay__" subnodes are skipped, by reverting the logic and using continue. This also reduces indentation level. Signed-off-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Rob Herring <[email protected]>
1 parent 35e691e commit 589b754

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

drivers/of/overlay.c

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -573,18 +573,19 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs,
573573
cnt = 0;
574574
for_each_child_of_node(tree, node) {
575575
overlay_node = of_get_child_by_name(node, "__overlay__");
576-
if (overlay_node) {
577-
fragment = &fragments[cnt];
578-
fragment->overlay = overlay_node;
579-
fragment->target = find_target_node(node);
580-
if (!fragment->target) {
581-
of_node_put(fragment->overlay);
582-
ret = -EINVAL;
583-
goto err_free_fragments;
584-
}
576+
if (!overlay_node)
577+
continue;
585578

586-
cnt++;
579+
fragment = &fragments[cnt];
580+
fragment->overlay = overlay_node;
581+
fragment->target = find_target_node(node);
582+
if (!fragment->target) {
583+
of_node_put(fragment->overlay);
584+
ret = -EINVAL;
585+
goto err_free_fragments;
587586
}
587+
588+
cnt++;
588589
}
589590

590591
/*

0 commit comments

Comments
 (0)